commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in xdr_align_pages)
has added a pr_info that floods dmesg when booting via NFS.
There is also a note in the commit log: "Warning! Contains debugging printks!"
,so change it to pr_debug instead.
Signed-off-by: Fabio Estevam <[email protected]>
---
net/sunrpc/xdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index e30842b..6983efc 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -749,7 +749,7 @@ static unsigned int xdr_align_pages(struct xdr_stream *xdr, unsigned int len)
xdr_shrink_pagelen(buf, buf->page_len - len);
xdr->nwords = XDR_QUADLEN(buf->len - cur);
} else
- pr_info("%s: Optimised away a data move!\n", __func__);
+ pr_debug("%s: Optimised away a data move!\n", __func__);
return len;
}
--
1.7.9.5
> -----Original Message-----
> From: Marek Vasut [mailto:[email protected]]
> Sent: Thursday, October 04, 2012 7:25 AM
> To: Fabio Estevam
> Cc: [email protected]; Myklebust, Trond; [email protected];
> [email protected]
> Subject: Re: [PATCH] net: sunrpc: xdr: Change message to pr_debug level
>
> Dear Fabio Estevam,
>
> > commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in
> > xdr_align_pages) has added a pr_info that floods dmesg when booting
> > via NFS.
> >
> > There is also a note in the commit log: "Warning! Contains debugging
> > printks!"
> >
...which meant that it contained debugging code, and was obviously not appropriate for merging upstream. The final version has already dropped the debugging printks.
Trond
Dear Fabio Estevam,
> commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in
> xdr_align_pages) has added a pr_info that floods dmesg when booting via
> NFS.
>
> There is also a note in the commit log: "Warning! Contains debugging
> printks!"
>
> ,so change it to pr_debug instead.
>
> Signed-off-by: Fabio Estevam <[email protected]>
Reviewed-by: Marek Vasut <[email protected]>
> ---
> net/sunrpc/xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index e30842b..6983efc 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -749,7 +749,7 @@ static unsigned int xdr_align_pages(struct xdr_stream
> *xdr, unsigned int len) xdr_shrink_pagelen(buf, buf->page_len - len);
> xdr->nwords = XDR_QUADLEN(buf->len - cur);
> } else
> - pr_info("%s: Optimised away a data move!\n", __func__);
> + pr_debug("%s: Optimised away a data move!\n", __func__);
> return len;
> }
Best regards,
Marek Vasut
Dear Myklebust, Trond,
> > -----Original Message-----
> > From: Marek Vasut [mailto:[email protected]]
> > Sent: Thursday, October 04, 2012 7:25 AM
> > To: Fabio Estevam
> > Cc: [email protected]; Myklebust, Trond; [email protected];
> > [email protected]
> > Subject: Re: [PATCH] net: sunrpc: xdr: Change message to pr_debug level
> >
> > Dear Fabio Estevam,
> >
> > > commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in
> > > xdr_align_pages) has added a pr_info that floods dmesg when booting
> > > via NFS.
> > >
> > > There is also a note in the commit log: "Warning! Contains debugging
> > > printks!"
>
> ...which meant that it contained debugging code, and was obviously not
> appropriate for merging upstream. The final version has already dropped
> the debugging printks.
Uh oh, the version with debug prints made it into -next .
Best regards,
Marek Vasut