2012-05-21 10:41:39

by Boaz Harrosh

Subject: [PATCH] SQUASHME: pnfsd-lexp: Fix compiler warning when CONFIG_SUNRPC_DEBUG is not set

Fix "Unused variable" warning if CONFIG_SUNRPC_DEBUG is not set

Signed-off-by: Boaz Harrosh <[email protected]>
---
git diff --stat -p -M fs/nfsd/nfs4pnfsds.c
fs/nfsd/nfs4pnfsds.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/nfsd/nfs4pnfsds.c b/fs/nfsd/nfs4pnfsds.c
index 2732f20..ab67523 100644
--- a/fs/nfsd/nfs4pnfsds.c
+++ b/fs/nfsd/nfs4pnfsds.c
@@ -170,10 +170,9 @@ static int stateid_hashval(stateid_t *stidp)
hashval = stateid_hashval(stidp);
list_for_each_entry(local, &ds_stid_hashtbl[hashval], ds_hash)
if (!memcmp(&local->ds_stid.si_opaque, &stidp->si_opaque, sizeof(stidp->si_opaque))) {
- stateid_t *sid = &local->ds_stid;
dprintk("NFSD: %s <-- %p ds_flags %lx " STATEID_FMT "\n",
__func__, local, local->ds_flags,
- STATEID_VAL(sid));
+ STATEID_VAL(&local->ds_stid));
return local;
}
return NULL;

2012-05-21 15:43:42

by Boaz Harrosh

Subject: Re: [PATCH] SQUASHME: pnfsd-lexp: Fix compiler warning when CONFIG_SUNRPC_DEBUG is not set

On 05/21/2012 06:10 PM, Benny Halevy wrote:

> On 2012-05-21 13:41, Boaz Harrosh wrote:
>>
>> Fix "Unused variable" warning if CONFIG_SUNRPC_DEBUG is not set
>>
>
> Merged, thanks!
>


Not that I'm at the stage where I don't configure CONFIG_SUNRPC_DEBUG=y
It was recently changed and my oldconfig base removed it.

Actually I got lucky, because I would have run without dprints
and would have pulled my hair what's going on with my setup.

I wish it would stay to protect me for a while ;-)

Thanks
Boaz

2012-05-21 15:10:35

by Benny Halevy

Subject: Re: [PATCH] SQUASHME: pnfsd-lexp: Fix compiler warning when CONFIG_SUNRPC_DEBUG is not set

On 2012-05-21 13:41, Boaz Harrosh wrote:
>
> Fix "Unused variable" warning if CONFIG_SUNRPC_DEBUG is not set
>

Merged, thanks!

> Signed-off-by: Boaz Harrosh <[email protected]>
> ---
> git diff --stat -p -M fs/nfsd/nfs4pnfsds.c
> fs/nfsd/nfs4pnfsds.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4pnfsds.c b/fs/nfsd/nfs4pnfsds.c
> index 2732f20..ab67523 100644
> --- a/fs/nfsd/nfs4pnfsds.c
> +++ b/fs/nfsd/nfs4pnfsds.c
> @@ -170,10 +170,9 @@ static int stateid_hashval(stateid_t *stidp)
> hashval = stateid_hashval(stidp);
> list_for_each_entry(local, &ds_stid_hashtbl[hashval], ds_hash)
> if (!memcmp(&local->ds_stid.si_opaque, &stidp->si_opaque, sizeof(stidp->si_opaque))) {
> - stateid_t *sid = &local->ds_stid;
> dprintk("NFSD: %s <-- %p ds_flags %lx " STATEID_FMT "\n",
> __func__, local, local->ds_flags,
> - STATEID_VAL(sid));
> + STATEID_VAL(&local->ds_stid));
> return local;
> }
> return NULL;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html