2013-03-11 12:05:59

by fanchaoting

Subject: [PATCH] ctl: should return NULL when dmsetup fail in find_dm_name

when dmsetup fail in find_dm_name, it should return NULL,if don't
do it. it will cause core dump in get_dm when do free(name).

Signed-off-by: fanchaoting<[email protected]>

---
ctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ctl.c b/ctl.c
index 2071b0e..0ac1c44 100644
--- a/ctl.c
+++ b/ctl.c
@@ -489,7 +489,7 @@ find_dm_name(int major, int minor)
if (((fd = get_output("/sbin/dmsetup", argv)) == -1) ||
((fp = fdopen(fd, "r")) == NULL)) {
printf("%s: get_output/fdopen failed\n", __func__);
- return;
+ return NULL;
}
while (fgets(buf, sizeof (buf), fp) != NULL) {
t = __token_init(buf, '\t');
--
1.7.1

2013-03-25 10:02:54

by fanchaoting

Subject: Re: [PATCH] ctl: should return NULL when dmsetup fail in find_dm_name

Benny Halevy 写道:
> On 2013-03-11 14:06, fanchaoting wrote:
>> when dmsetup fail in find_dm_name, it should return NULL,if don't
>> do it. it will cause core dump in get_dm when do free(name).
>
> Thanks, but what version are you using?
> This was already fixed here:
> http://git.linux-nfs.org/?p=bhalevy/pnfsd-block-ctl.git;a=commitdiff;h=9082efe1dc12248e530d4200d7150a286abea922
>
> Please update to the latest version
> git://linux-nfs.org/~bhalevy/pnfsd-block-ctl.git
>

thanks for telling me .

> Benny
>
>> Signed-off-by: fanchaoting<[email protected]>
>>
>> ---
>> ctl.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/ctl.c b/ctl.c
>> index 2071b0e..0ac1c44 100644
>> --- a/ctl.c
>> +++ b/ctl.c
>> @@ -489,7 +489,7 @@ find_dm_name(int major, int minor)
>> if (((fd = get_output("/sbin/dmsetup", argv)) == -1) ||
>> ((fp = fdopen(fd, "r")) == NULL)) {
>> printf("%s: get_output/fdopen failed\n", __func__);
>> - return;
>> + return NULL;
>> }
>> while (fgets(buf, sizeof (buf), fp) != NULL) {
>> t = __token_init(buf, '\t');
>> --
>> 1.7.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>

2013-03-25 09:34:21

by Benny Halevy

Subject: Re: [PATCH] ctl: should return NULL when dmsetup fail in find_dm_name

On 2013-03-11 14:06, fanchaoting wrote:
> when dmsetup fail in find_dm_name, it should return NULL,if don't
> do it. it will cause core dump in get_dm when do free(name).

Thanks, but what version are you using?
This was already fixed here:
http://git.linux-nfs.org/?p=bhalevy/pnfsd-block-ctl.git;a=commitdiff;h=9082efe1dc12248e530d4200d7150a286abea922

Please update to the latest version
git://linux-nfs.org/~bhalevy/pnfsd-block-ctl.git

Benny

>
> Signed-off-by: fanchaoting<[email protected]>
>
> ---
> ctl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ctl.c b/ctl.c
> index 2071b0e..0ac1c44 100644
> --- a/ctl.c
> +++ b/ctl.c
> @@ -489,7 +489,7 @@ find_dm_name(int major, int minor)
> if (((fd = get_output("/sbin/dmsetup", argv)) == -1) ||
> ((fp = fdopen(fd, "r")) == NULL)) {
> printf("%s: get_output/fdopen failed\n", __func__);
> - return;
> + return NULL;
> }
> while (fgets(buf, sizeof (buf), fp) != NULL) {
> t = __token_init(buf, '\t');
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>