2013-04-10 06:05:34

by fanchaoting

Subject: [PATCH] nfsd: remove some useless code

the "list_empty(&oo->oo_owner.so_stateids)" is aways true ,
so we remove it.

Signed-off-by: fanchaoting <[email protected]>
---
fs/nfsd/nfs4state.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 2e27430..e9f1d37 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -3830,8 +3830,7 @@ nfsd4_close(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
* In the 4.0 case we need to keep the owners around a
* little while to handle CLOSE replay.
*/
- if (list_empty(&oo->oo_owner.so_stateids))
- move_to_close_lru(oo, SVC_NET(rqstp));
+ move_to_close_lru(oo, SVC_NET(rqstp));
}
}
out:
--
1.7.1

2013-04-11 14:42:23

by J. Bruce Fields

Subject: Re: [PATCH 2/2] nfsd: remove some useless code

On Thu, Apr 11, 2013 at 09:24:13PM +0800, fanchaoting wrote:
>
> the "list_empty(&oo->oo_owner.so_stateids)" is aways true ,
> so we remove it.

Thanks! Applying.--b.

>
> Signed-off-by: fanchaoting <[email protected]>
> ---
> fs/nfsd/nfs4state.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 2e27430..e9f1d37 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -3830,8 +3830,7 @@ nfsd4_close(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
> * In the 4.0 case we need to keep the owners around a
> * little while to handle CLOSE replay.
> */
> - if (list_empty(&oo->oo_owner.so_stateids))
> - move_to_close_lru(oo, SVC_NET(rqstp));
> + move_to_close_lru(oo, SVC_NET(rqstp));
> }
> }
> out:
> --
> 1.7.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>

2013-04-11 13:24:19

by fanchaoting

Subject: [PATCH 2/2] nfsd: remove some useless code

the "list_empty(&oo->oo_owner.so_stateids)" is aways true ,
so we remove it.

Signed-off-by: fanchaoting <[email protected]>
---
fs/nfsd/nfs4state.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 2e27430..e9f1d37 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -3830,8 +3830,7 @@ nfsd4_close(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
* In the 4.0 case we need to keep the owners around a
* little while to handle CLOSE replay.
*/
- if (list_empty(&oo->oo_owner.so_stateids))
- move_to_close_lru(oo, SVC_NET(rqstp));
+ move_to_close_lru(oo, SVC_NET(rqstp));
}
}
out:
--
1.7.1