2013-10-24 02:36:14

by Wang Weidong

Subject: [PACTH net-next] SUNRPC: remove an unnecessary if statement

If req allocated failed just goto out_free, no need to check the
'i < num_prealloc'. There is just code simplification, no
functional changes.

Signed-off-by: Wang Weidong <[email protected]>
---
net/sunrpc/xprt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c
index 095363e..a8e20de 100644
--- a/net/sunrpc/xprt.c
+++ b/net/sunrpc/xprt.c
@@ -1087,11 +1087,9 @@ struct rpc_xprt *xprt_alloc(struct net *net, size_t size,
for (i = 0; i < num_prealloc; i++) {
req = kzalloc(sizeof(struct rpc_rqst), GFP_KERNEL);
if (!req)
- break;
+ goto out_free;
list_add(&req->rq_list, &xprt->free);
}
- if (i < num_prealloc)
- goto out_free;
if (max_alloc > num_prealloc)
xprt->max_reqs = max_alloc;
else
-- 1.7.12

2013-10-24 12:32:05

by Ding Tianhong

Subject: Re: [PACTH net-next] SUNRPC: remove an unnecessary if statement

On 2013/10/24 10:35, wangweidong wrote:
> If req allocated failed just goto out_free, no need to check the
> 'i < num_prealloc'. There is just code simplification, no
> functional changes.
>
> Signed-off-by: Wang Weidong <[email protected]>
> ---
> net/sunrpc/xprt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c
> index 095363e..a8e20de 100644
> --- a/net/sunrpc/xprt.c
> +++ b/net/sunrpc/xprt.c
> @@ -1087,11 +1087,9 @@ struct rpc_xprt *xprt_alloc(struct net *net, size_t size,
> for (i = 0; i < num_prealloc; i++) {
> req = kzalloc(sizeof(struct rpc_rqst), GFP_KERNEL);
> if (!req)
> - break;
> + goto out_free;
> list_add(&req->rq_list, &xprt->free);
> }
> - if (i < num_prealloc)
> - goto out_free;
> if (max_alloc > num_prealloc)
> xprt->max_reqs = max_alloc;
> else
> -- 1.7.12
>
>

Acked-by: Ding Tianhong <[email protected]>

>
>
> .
>