2013-11-08 07:23:49

by Weng Meiling

Subject: [PATCH] svcrpc: remove the unnecessary evaluation

From: Weng Meiling <[email protected]>

Signed-off-by: Weng Meiling <[email protected]>
---
net/sunrpc/svc.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index b974571..e7fbe36 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -1104,8 +1104,6 @@ svc_process_common(struct svc_rqst *rqstp, struct kvec *argv, struct kvec *resv)
rqstp->rq_vers = vers = svc_getnl(argv); /* version number */
rqstp->rq_proc = proc = svc_getnl(argv); /* procedure number */

- progp = serv->sv_program;
-
for (progp = serv->sv_program; progp; progp = progp->pg_next)
if (prog == progp->pg_prog)
break;
--
1.8.3.1

2013-11-13 15:57:04

by J. Bruce Fields

Subject: Re: [PATCH] svcrpc: remove the unnecessary evaluation

On Fri, Nov 08, 2013 at 03:23:12PM +0800, Weng Meiling wrote:
>
> From: Weng Meiling <[email protected]>

Huh. Looks like that was introduced with "[PATCH] knfsd: make sure
svc_process call the correct pg_authenticate for multi-service port" in
2005. OK! Applied.

--b.

>
> Signed-off-by: Weng Meiling <[email protected]>
> ---
> net/sunrpc/svc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index b974571..e7fbe36 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -1104,8 +1104,6 @@ svc_process_common(struct svc_rqst *rqstp, struct kvec *argv, struct kvec *resv)
> rqstp->rq_vers = vers = svc_getnl(argv); /* version number */
> rqstp->rq_proc = proc = svc_getnl(argv); /* procedure number */
>
> - progp = serv->sv_program;
> -
> for (progp = serv->sv_program; progp; progp = progp->pg_next)
> if (prog == progp->pg_prog)
> break;
> --
> 1.8.3.1
>
>
>
>