2013-12-16 02:49:03

by Kinglong Mee

Subject: [PATCH] nfsd: get rid of unused function definition

commit 557ce2646e775f6bda734dd92b10d4780874b9c7
"nfsd41: replace page based DRC with buffer based DRC"
have remove unused nfsd4_set_statp, but miss the function definition.

Signed-off-by: Kinglong Mee <[email protected]>
---
fs/nfsd/cache.h | 8 --------
1 file changed, 8 deletions(-)

diff --git a/fs/nfsd/cache.h b/fs/nfsd/cache.h
index d5c5b3e..b582f9a 100644
--- a/fs/nfsd/cache.h
+++ b/fs/nfsd/cache.h
@@ -84,12 +84,4 @@ int nfsd_cache_lookup(struct svc_rqst *);
void nfsd_cache_update(struct svc_rqst *, int, __be32 *);
int nfsd_reply_cache_stats_open(struct inode *, struct file *);

-#ifdef CONFIG_NFSD_V4
-void nfsd4_set_statp(struct svc_rqst *rqstp, __be32 *statp);
-#else /* CONFIG_NFSD_V4 */
-static inline void nfsd4_set_statp(struct svc_rqst *rqstp, __be32 *statp)
-{
-}
-#endif /* CONFIG_NFSD_V4 */
-
#endif /* NFSCACHE_H */
--
1.8.4.2

2013-12-19 18:55:16

by J. Bruce Fields

Subject: Re: [PATCH] nfsd: get rid of unused function definition

On Mon, Dec 16, 2013 at 10:48:49AM +0800, Kinglong Mee wrote:
> commit 557ce2646e775f6bda734dd92b10d4780874b9c7
> "nfsd41: replace page based DRC with buffer based DRC"
> have remove unused nfsd4_set_statp, but miss the function definition.

Thanks, applying. (May not actually get pushed out till the new year.)

--b.

>
> Signed-off-by: Kinglong Mee <[email protected]>
> ---
> fs/nfsd/cache.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/fs/nfsd/cache.h b/fs/nfsd/cache.h
> index d5c5b3e..b582f9a 100644
> --- a/fs/nfsd/cache.h
> +++ b/fs/nfsd/cache.h
> @@ -84,12 +84,4 @@ int nfsd_cache_lookup(struct svc_rqst *);
> void nfsd_cache_update(struct svc_rqst *, int, __be32 *);
> int nfsd_reply_cache_stats_open(struct inode *, struct file *);
>
> -#ifdef CONFIG_NFSD_V4
> -void nfsd4_set_statp(struct svc_rqst *rqstp, __be32 *statp);
> -#else /* CONFIG_NFSD_V4 */
> -static inline void nfsd4_set_statp(struct svc_rqst *rqstp, __be32 *statp)
> -{
> -}
> -#endif /* CONFIG_NFSD_V4 */
> -
> #endif /* NFSCACHE_H */
> --
> 1.8.4.2