2013-12-23 09:31:26

by Kinglong Mee

Subject: [PATCH] NFSD: fix a bug which causing nfsd deny CREATE_SESSION

check_forechannel_attrs have get drc memory,
nfsd must put it when check_backchannel_attrs failed.

After many requests with bad back channel attrs,
nfsd will deny any client's CREATE_SESSION forever.

A new test case named CSESS29 for pynfs will send in another mail.

Signed-off-by: Kinglong Mee <[email protected]>
---
fs/nfsd/nfs4state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 105d6fa..4e2c9ba 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1913,7 +1913,7 @@ nfsd4_create_session(struct svc_rqst *rqstp,
return status;
status = check_backchannel_attrs(&cr_ses->back_channel);
if (status)
- return status;
+ goto out_release_drc_mem;
status = nfserr_jukebox;
new = alloc_session(&cr_ses->fore_channel);
if (!new)
--
1.8.4.2

2014-01-03 21:34:57

by J. Bruce Fields

Subject: Re: [PATCH] NFSD: fix a bug which causing nfsd deny CREATE_SESSION

On Mon, Dec 23, 2013 at 05:31:21PM +0800, Kinglong Mee wrote:
> check_forechannel_attrs have get drc memory,
> nfsd must put it when check_backchannel_attrs failed.
>
> After many requests with bad back channel attrs,
> nfsd will deny any client's CREATE_SESSION forever.

Thanks, applying.--b.

>
> A new test case named CSESS29 for pynfs will send in another mail.
>
> Signed-off-by: Kinglong Mee <[email protected]>
> ---
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 105d6fa..4e2c9ba 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -1913,7 +1913,7 @@ nfsd4_create_session(struct svc_rqst *rqstp,
> return status;
> status = check_backchannel_attrs(&cr_ses->back_channel);
> if (status)
> - return status;
> + goto out_release_drc_mem;
> status = nfserr_jukebox;
> new = alloc_session(&cr_ses->fore_channel);
> if (!new)
> --
> 1.8.4.2