2014-05-23 12:53:27

by Kinglong Mee

Subject: [PATCH 1/5] NFSD: Cleanup unneeded including linux/user_namespace.h

commit 4c1e1b34d5c800ad3ac9a7e2805b0bea70ad2278 using kuid/kgid for
ex_anon_uid/ex_anon_gid, user_namespace.h is not needed now, clean it.

Signed-off-by: Kinglong Mee <[email protected]>
---
fs/nfsd/auth.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/nfsd/auth.c b/fs/nfsd/auth.c
index 2645be4..1042325 100644
--- a/fs/nfsd/auth.c
+++ b/fs/nfsd/auth.c
@@ -1,7 +1,6 @@
/* Copyright (C) 1995, 1996 Olaf Kirch <[email protected]> */

#include <linux/sched.h>
-#include <linux/user_namespace.h>
#include "nfsd.h"
#include "auth.h"

--
1.9.3

2014-05-23 14:18:56

by J. Bruce Fields

Subject: Re: [PATCH 1/5] NFSD: Cleanup unneeded including linux/user_namespace.h

Thanks, applied all five.

On Fri, May 23, 2014 at 08:53:05PM +0800, Kinglong Mee wrote:
> commit 4c1e1b34d5c800ad3ac9a7e2805b0bea70ad2278 using kuid/kgid for

In future, when referring to another commit, could you also include the
summary line? E.g.: Commit 8f6c5ffc8987 ("kernel/groups.c: remove
return value of set_groups") removed the last use of "ret"....

--b.

> ex_anon_uid/ex_anon_gid, user_namespace.h is not needed now, clean it.
>
> Signed-off-by: Kinglong Mee <[email protected]>
> ---
> fs/nfsd/auth.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/auth.c b/fs/nfsd/auth.c
> index 2645be4..1042325 100644
> --- a/fs/nfsd/auth.c
> +++ b/fs/nfsd/auth.c
> @@ -1,7 +1,6 @@
> /* Copyright (C) 1995, 1996 Olaf Kirch <[email protected]> */
>
> #include <linux/sched.h>
> -#include <linux/user_namespace.h>
> #include "nfsd.h"
> #include "auth.h"
>
> --
> 1.9.3
>

2014-05-23 14:21:11

by Kinglong Mee

Subject: Re: [PATCH 1/5] NFSD: Cleanup unneeded including linux/user_namespace.h

On 5/23/2014 22:18, J. Bruce Fields wrote:
> Thanks, applied all five.
>
> On Fri, May 23, 2014 at 08:53:05PM +0800, Kinglong Mee wrote:
>> commit 4c1e1b34d5c800ad3ac9a7e2805b0bea70ad2278 using kuid/kgid for
>
> In future, when referring to another commit, could you also include the
> summary line? E.g.: Commit 8f6c5ffc8987 ("kernel/groups.c: remove
> return value of set_groups") removed the last use of "ret"....

Got it, i will do that in the future.

thanks,
Kinglong Mee

>
> --b.
>
>> ex_anon_uid/ex_anon_gid, user_namespace.h is not needed now, clean it.
>>
>> Signed-off-by: Kinglong Mee <[email protected]>
>> ---
>> fs/nfsd/auth.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/nfsd/auth.c b/fs/nfsd/auth.c
>> index 2645be4..1042325 100644
>> --- a/fs/nfsd/auth.c
>> +++ b/fs/nfsd/auth.c
>> @@ -1,7 +1,6 @@
>> /* Copyright (C) 1995, 1996 Olaf Kirch <[email protected]> */
>>
>> #include <linux/sched.h>
>> -#include <linux/user_namespace.h>
>> #include "nfsd.h"
>> #include "auth.h"
>>
>> --
>> 1.9.3
>>
>