2015-04-05 14:09:53

by Kinglong Mee

Subject: [PATCH] nfs-utils: add missing comma for exports ent

When using pnfs with "fsid=0", exportfs prints error as,

# exportfs -a
exportfs: /var/lib/nfs/etab:1: unknown keyword "no_pnfsfsid=0"

Commit cdd16bef98 ("nfs-utils: add support for the "pnfs" export option")
miss the comma after "pnfs"/"on_pnfs" operation.

Signed-off-by: Kinglong Mee <[email protected]>
---
support/nfs/exports.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/nfs/exports.c b/support/nfs/exports.c
index 9b325b9..761a046 100644
--- a/support/nfs/exports.c
+++ b/support/nfs/exports.c
@@ -275,7 +275,7 @@ putexportent(struct exportent *ep)
"no_" : "");
if (ep->e_flags & NFSEXP_NOREADDIRPLUS)
fprintf(fp, "nordirplus,");
- fprintf(fp, "%spnfs", (ep->e_flags & NFSEXP_PNFS)? "" : "no_");
+ fprintf(fp, "%spnfs,", (ep->e_flags & NFSEXP_PNFS)? "" : "no_");
if (ep->e_flags & NFSEXP_FSID) {
fprintf(fp, "fsid=%d,", ep->e_fsid);
}
--
2.3.4

2015-04-06 12:01:48

by Christoph Hellwig

Subject: Re: [PATCH] nfs-utils: add missing comma for exports ent

Thanks, sorry for messing up the last minute update..

Reviewed-by: Christoph Hellwig <[email protected]>

2015-04-06 21:14:37

by Steve Dickson

Subject: Re: [PATCH] nfs-utils: add missing comma for exports ent

On 04/05/2015 10:09 AM, Kinglong Mee wrote:
> When using pnfs with "fsid=0", exportfs prints error as,
>
> # exportfs -a
> exportfs: /var/lib/nfs/etab:1: unknown keyword "no_pnfsfsid=0"
>
> Commit cdd16bef98 ("nfs-utils: add support for the "pnfs" export option")
> miss the comma after "pnfs"/"on_pnfs" operation.
>
> Signed-off-by: Kinglong Mee <[email protected]>
Committed...

steved.

> ---
> support/nfs/exports.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/nfs/exports.c b/support/nfs/exports.c
> index 9b325b9..761a046 100644
> --- a/support/nfs/exports.c
> +++ b/support/nfs/exports.c
> @@ -275,7 +275,7 @@ putexportent(struct exportent *ep)
> "no_" : "");
> if (ep->e_flags & NFSEXP_NOREADDIRPLUS)
> fprintf(fp, "nordirplus,");
> - fprintf(fp, "%spnfs", (ep->e_flags & NFSEXP_PNFS)? "" : "no_");
> + fprintf(fp, "%spnfs,", (ep->e_flags & NFSEXP_PNFS)? "" : "no_");
> if (ep->e_flags & NFSEXP_FSID) {
> fprintf(fp, "fsid=%d,", ep->e_fsid);
> }
>