2015-10-28 17:19:58

by Scott Mayhew

Subject: [nfs-utils PATCH] exportfs: Restore the EAI_NONAME check in host_pton()

Commit d89e3fc7 removed the EAI_NONAME check altogether instead of just
moving the NULL check. This causes exportfs -u to incorrectly exit
with 1 whenever there's more than one MCL_FQDN export in the exportlist.

Signed-off-by: Scott Mayhew <[email protected]>
---
support/export/hostname.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/support/export/hostname.c b/support/export/hostname.c
index 169baa5..7a44d42 100644
--- a/support/export/hostname.c
+++ b/support/export/hostname.c
@@ -134,6 +134,8 @@ host_pton(const char *paddr)
break;
}
return ai;
+ case EAI_NONAME:
+ break;
case EAI_SYSTEM:
xlog(D_GENERAL, "%s: failed to convert %s: (%d) %m",
__func__, paddr, errno);
--
2.4.3

2015-11-04 21:51:40

by Steve Dickson

Subject: Re: [nfs-utils PATCH] exportfs: Restore the EAI_NONAME check in host_pton()

On 10/28/2015 01:19 PM, Scott Mayhew wrote:
> Commit d89e3fc7 removed the EAI_NONAME check altogether instead of just
> moving the NULL check. This causes exportfs -u to incorrectly exit
> with 1 whenever there's more than one MCL_FQDN export in the exportlist.
>
> Signed-off-by: Scott Mayhew <[email protected]>
Committed...

steved.
> ---
> support/export/hostname.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/support/export/hostname.c b/support/export/hostname.c
> index 169baa5..7a44d42 100644
> --- a/support/export/hostname.c
> +++ b/support/export/hostname.c
> @@ -134,6 +134,8 @@ host_pton(const char *paddr)
> break;
> }
> return ai;
> + case EAI_NONAME:
> + break;
> case EAI_SYSTEM:
> xlog(D_GENERAL, "%s: failed to convert %s: (%d) %m",
> __func__, paddr, errno);
>