2016-04-29 13:25:58

by Scott Mayhew

Subject: [nfs-utils PATCH] exportfs: add the debug option

Since calling xlog(D_GENERAL) will cause exportfs to exit with a status
of 1, there really should be a way to see those messages for debugging
purposes.

Signed-off-by: Scott Mayhew <[email protected]>
---
utils/exportfs/exportfs.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
index a9151ff..a5eb156 100644
--- a/utils/exportfs/exportfs.c
+++ b/utils/exportfs/exportfs.c
@@ -108,11 +108,14 @@ main(int argc, char **argv)
xlog_stderr(1);
xlog_syslog(0);

- while ((c = getopt(argc, argv, "afhio:ruvs")) != EOF) {
+ while ((c = getopt(argc, argv, "ad:fhio:ruvs")) != EOF) {
switch(c) {
case 'a':
f_all = 1;
break;
+ case 'd':
+ xlog_sconfig(optarg, 1);
+ break;
case 'f':
force_flush = 1;
break;
--
2.4.11

2016-04-29 15:09:32

by Steve Dickson

Subject: Re: [nfs-utils PATCH] exportfs: add the debug option

On 04/29/2016 09:25 AM, Scott Mayhew wrote:
> Since calling xlog(D_GENERAL) will cause exportfs to exit with a status
> of 1, there really should be a way to see those messages for debugging
> purposes.
>
> Signed-off-by: Scott Mayhew <[email protected]>
> ---
> utils/exportfs/exportfs.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index a9151ff..a5eb156 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -108,11 +108,14 @@ main(int argc, char **argv)
> xlog_stderr(1);
> xlog_syslog(0);
>
> - while ((c = getopt(argc, argv, "afhio:ruvs")) != EOF) {
> + while ((c = getopt(argc, argv, "ad:fhio:ruvs")) != EOF) {
> switch(c) {
> case 'a':
> f_all = 1;
> break;
> + case 'd':
> + xlog_sconfig(optarg, 1);
> + break;
I'm all for doing this but there needs to be an
usage() update and man page update. For the man
page update, just rip the verbiage out of the
mountd man page since they are the same.

steved.

> case 'f':
> force_flush = 1;
> break;
>