2012-09-05 06:38:04

by Wei Yongjun

Subject: [PATCH] pnfsblock: use list_move_tail instead of list_del/list_add_tail

From: Wei Yongjun <[email protected]>

Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <[email protected]>
---
fs/nfs/blocklayout/extents.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/nfs/blocklayout/extents.c b/fs/nfs/blocklayout/extents.c
index 1f9a603..9c3e117 100644
--- a/fs/nfs/blocklayout/extents.c
+++ b/fs/nfs/blocklayout/extents.c
@@ -683,8 +683,7 @@ encode_pnfs_block_layoutupdate(struct pnfs_block_layout *bl,
p = xdr_encode_hyper(p, lce->bse_length << SECTOR_SHIFT);
p = xdr_encode_hyper(p, 0LL);
*p++ = cpu_to_be32(PNFS_BLOCK_READWRITE_DATA);
- list_del(&lce->bse_node);
- list_add_tail(&lce->bse_node, &bl->bl_committing);
+ list_move_tail(&lce->bse_node, &bl->bl_committing);
bl->bl_count--;
count++;
}

2012-09-10 02:08:30

by Peng, Tao

Subject: RE: [PATCH] pnfsblock: use list_move_tail instead of list_del/list_add_tail

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBsaW51eC1uZnMtb3duZXJAdmdl
ci5rZXJuZWwub3JnIFttYWlsdG86bGludXgtbmZzLW93bmVyQHZnZXIua2VybmVsLm9yZ10gT24g
QmVoYWxmIE9mIFdlaQ0KPiBZb25nanVuDQo+IFNlbnQ6IFdlZG5lc2RheSwgU2VwdGVtYmVyIDA1
LCAyMDEyIDI6MzggUE0NCj4gVG86IFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tDQo+IENjOiB5
b25nanVuX3dlaUB0cmVuZG1pY3JvLmNvbS5jbjsgbGludXgtbmZzQHZnZXIua2VybmVsLm9yZw0K
PiBTdWJqZWN0OiBbUEFUQ0hdIHBuZnNibG9jazogdXNlIGxpc3RfbW92ZV90YWlsIGluc3RlYWQg
b2YgbGlzdF9kZWwvbGlzdF9hZGRfdGFpbA0KPiANCj4gRnJvbTogV2VpIFlvbmdqdW4gPHlvbmdq
dW5fd2VpQHRyZW5kbWljcm8uY29tLmNuPg0KPiANCj4gVXNpbmcgbGlzdF9tb3ZlX3RhaWwoKSBp
bnN0ZWFkIG9mIGxpc3RfZGVsKCkgKyBsaXN0X2FkZF90YWlsKCkuDQo+IA0KPiBzcGF0Y2ggd2l0
aCBhIHNlbWFudGljIG1hdGNoIGlzIHVzZWQgdG8gZm91bmQgdGhpcyBwcm9ibGVtLg0KPiAoaHR0
cDovL2NvY2NpbmVsbGUubGlwNi5mci8pDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBXZWkgWW9uZ2p1
biA8eW9uZ2p1bl93ZWlAdHJlbmRtaWNyby5jb20uY24+DQpUaGlzIGxvb2tzIGdvb2QuIFRoYW5r
cyENCg0KUmV2aWV3ZWQtYnk6IFBlbmcgVGFvIDx0YW8ucGVuZ0BlbWMuY29tPg0KPiAtLS0NCj4g
IGZzL25mcy9ibG9ja2xheW91dC9leHRlbnRzLmMgfCAzICstLQ0KPiAgMSBmaWxlIGNoYW5nZWQs
IDEgaW5zZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2ZzL25m
cy9ibG9ja2xheW91dC9leHRlbnRzLmMgYi9mcy9uZnMvYmxvY2tsYXlvdXQvZXh0ZW50cy5jDQo+
IGluZGV4IDFmOWE2MDMuLjljM2UxMTcgMTAwNjQ0DQo+IC0tLSBhL2ZzL25mcy9ibG9ja2xheW91
dC9leHRlbnRzLmMNCj4gKysrIGIvZnMvbmZzL2Jsb2NrbGF5b3V0L2V4dGVudHMuYw0KPiBAQCAt
NjgzLDggKzY4Myw3IEBAIGVuY29kZV9wbmZzX2Jsb2NrX2xheW91dHVwZGF0ZShzdHJ1Y3QgcG5m
c19ibG9ja19sYXlvdXQgKmJsLA0KPiAgCQlwID0geGRyX2VuY29kZV9oeXBlcihwLCBsY2UtPmJz
ZV9sZW5ndGggPDwgU0VDVE9SX1NISUZUKTsNCj4gIAkJcCA9IHhkcl9lbmNvZGVfaHlwZXIocCwg
MExMKTsNCj4gIAkJKnArKyA9IGNwdV90b19iZTMyKFBORlNfQkxPQ0tfUkVBRFdSSVRFX0RBVEEp
Ow0KPiAtCQlsaXN0X2RlbCgmbGNlLT5ic2Vfbm9kZSk7DQo+IC0JCWxpc3RfYWRkX3RhaWwoJmxj
ZS0+YnNlX25vZGUsICZibC0+YmxfY29tbWl0dGluZyk7DQo+ICsJCWxpc3RfbW92ZV90YWlsKCZs
Y2UtPmJzZV9ub2RlLCAmYmwtPmJsX2NvbW1pdHRpbmcpOw0KPiAgCQlibC0+YmxfY291bnQtLTsN
Cj4gIAkJY291bnQrKzsNCj4gIAl9DQo+IA0KPiANCj4gLS0NCj4gVG8gdW5zdWJzY3JpYmUgZnJv
bSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LW5mcyIgaW4NCj4g
dGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcNCj4gTW9y
ZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5m
by5odG1sDQoNCg==