2017-10-03 18:43:24

by Matt Weber

[permalink] [raw]
Subject: [PATCH] nfs-utils: add missing include of stdint.h

Glibc bump to 2.26 exposed this missing header when building
with the following combination using an i386 internal toolchain.
gcc5.4.0
bin2.28.1
linux4.1.43

Upstream: https://bugzilla.linux-nfs.org/show_bug.cgi?id=312

Signed-off-by: Matthew Weber <[email protected]>
---
support/nsm/rpc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/support/nsm/rpc.c b/support/nsm/rpc.c
index 4e5f40e..d91c6ea 100644
--- a/support/nsm/rpc.c
+++ b/support/nsm/rpc.c
@@ -40,6 +40,7 @@

#include <time.h>
#include <stdbool.h>
+#include <stdint.h>
#include <string.h>
#include <unistd.h>
#include <fcntl.h>
--
1.9.1



2017-10-03 18:46:57

by Chuck Lever III

[permalink] [raw]
Subject: Re: [PATCH] nfs-utils: add missing include of stdint.h


> On Oct 3, 2017, at 2:33 PM, Matt Weber <[email protected]> wrote:
>
> Glibc bump to 2.26 exposed this missing header when building
> with the following combination using an i386 internal toolchain.
> gcc5.4.0
> bin2.28.1
> linux4.1.43
>
> Upstream: https://bugzilla.linux-nfs.org/show_bug.cgi?id=312
>
> Signed-off-by: Matthew Weber <[email protected]>

Reviewed-by: Chuck Lever <[email protected]>


> ---
> support/nsm/rpc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/support/nsm/rpc.c b/support/nsm/rpc.c
> index 4e5f40e..d91c6ea 100644
> --- a/support/nsm/rpc.c
> +++ b/support/nsm/rpc.c
> @@ -40,6 +40,7 @@
>
> #include <time.h>
> #include <stdbool.h>
> +#include <stdint.h>
> #include <string.h>
> #include <unistd.h>
> #include <fcntl.h>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Chuck Lever




2017-10-05 14:55:03

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH] nfs-utils: add missing include of stdint.h



On 10/03/2017 02:33 PM, Matt Weber wrote:
> Glibc bump to 2.26 exposed this missing header when building
> with the following combination using an i386 internal toolchain.
> gcc5.4.0
> bin2.28.1
> linux4.1.43
>
> Upstream: https://bugzilla.linux-nfs.org/show_bug.cgi?id=312
>
> Signed-off-by: Matthew Weber <[email protected]>
> ---
> support/nsm/rpc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/support/nsm/rpc.c b/support/nsm/rpc.c
> index 4e5f40e..d91c6ea 100644
> --- a/support/nsm/rpc.c
> +++ b/support/nsm/rpc.c
> @@ -40,6 +40,7 @@
>
> #include <time.h>
> #include <stdbool.h>
> +#include <stdint.h>
> #include <string.h>
> #include <unistd.h>
> #include <fcntl.h>
>
Committed....

steved.