2017-10-30 03:30:09

by Ryan Doyle

[permalink] [raw]
Subject: [PATCH] nfs-utils: display NFS RPC queue time for mountstats and nfs-iostat

Hi there

I've got a patch to display the NFS queue statistics for mountstats and nfsiostat exported in /proc/self/mountstats. The RTT and total execution time is currently displayed but I think it's also useful displaying how long the task was queued for too. If others agree, please feel free to apply it.

Cheers,
Ryan


Attachments:
report_nfs_queue_stats_v1.patch (4.37 kB)
report_nfs_queue_stats_v1.patch

2017-10-30 15:29:46

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH] nfs-utils: display NFS RPC queue time for mountstats and nfs-iostat



On 10/29/2017 11:30 PM, Ryan Doyle wrote:
> Hi there
>
> I've got a patch to display the NFS queue statistics for mountstats and nfsiostat exported in /proc/self/mountstats. The RTT and total execution time is currently displayed but I think it's also useful displaying how long the task was queued for too. If others agree, please feel free to apply it.

In the future please use the proper format for posting
a patch that is described in
https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html

Basically, inline the patch, have a subject and description
section and a proper Signed-off-by: line. But since I
found another bug while testing your patch and I'm about
to make a release I'll go ahead and add the Signed-off-by: line

Patch committed!

steved.