2022-11-21 19:21:05

by Steve Dickson

Subject: [PATCH] nfs4_getfacl: Initialize acl pointer to NULL

nfs4_getfacl.c: scope_hint: In function 'print_acl_from_path'
nfs4_getfacl.c:168:17: warning[-Wmaybe-uninitialized]:
'acl' may be used uninitialized in this function

Signed-off-by: Steve Dickson <[email protected]>
---
nfs4_getfacl/nfs4_getfacl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nfs4_getfacl/nfs4_getfacl.c b/nfs4_getfacl/nfs4_getfacl.c
index 954cf7e..ddb3005 100644
--- a/nfs4_getfacl/nfs4_getfacl.c
+++ b/nfs4_getfacl/nfs4_getfacl.c
@@ -148,7 +148,7 @@ out:

static void print_acl_from_path(const char *fpath, enum acl_type type)
{
- struct nfs4_acl *acl;
+ struct nfs4_acl *acl = NULL;

switch (type) {
case ACL_TYPE_ACL:
--
2.38.1

2022-11-22 13:14:12

by Steve Dickson

Subject: Re: [PATCH] nfs4_getfacl: Initialize acl pointer to NULL

On 11/21/22 2:14 PM, Steve Dickson wrote:
> nfs4_getfacl.c: scope_hint: In function 'print_acl_from_path'
> nfs4_getfacl.c:168:17: warning[-Wmaybe-uninitialized]:
> 'acl' may be used uninitialized in this function
>
> Signed-off-by: Steve Dickson <[email protected]>
Committed... (tag: nfs4-acl-tools-0.4.3-rc1)

steved.
> ---
> nfs4_getfacl/nfs4_getfacl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nfs4_getfacl/nfs4_getfacl.c b/nfs4_getfacl/nfs4_getfacl.c
> index 954cf7e..ddb3005 100644
> --- a/nfs4_getfacl/nfs4_getfacl.c
> +++ b/nfs4_getfacl/nfs4_getfacl.c
> @@ -148,7 +148,7 @@ out:
>
> static void print_acl_from_path(const char *fpath, enum acl_type type)
> {
> - struct nfs4_acl *acl;
> + struct nfs4_acl *acl = NULL;
>
> switch (type) {
> case ACL_TYPE_ACL: