2022-06-28 21:36:50

by Colin Ian King

Subject: [PATCH] nfsd: remove redundant assignment to variable len

Variable len is being assigned a value zero and this is never
read, it is being re-assigned later. The assignment is redundant
and can be removed.

Cleans up clang scan-build warning:
fs/nfsd/nfsctl.c:636:2: warning: Value stored to 'len' is never read

Signed-off-by: Colin Ian King <[email protected]>
---
fs/nfsd/nfsctl.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index 0621c2faf242..66c352bf61b1 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -633,7 +633,6 @@ static ssize_t __write_versions(struct file *file, char *buf, size_t size)
}

/* Now write current state into reply buffer */
- len = 0;
sep = "";
remaining = SIMPLE_TRANSACTION_LIMIT;
for (num=2 ; num <= 4 ; num++) {
--
2.35.3

2022-06-28 22:18:41

by Chuck Lever III

Subject: Re: [PATCH] nfsd: remove redundant assignment to variable len

> On Jun 28, 2022, at 5:25 PM, Colin Ian King <[email protected]> wrote:
>
> Variable len is being assigned a value zero and this is never
> read, it is being re-assigned later. The assignment is redundant
> and can be removed.
>
> Cleans up clang scan-build warning:
> fs/nfsd/nfsctl.c:636:2: warning: Value stored to 'len' is never read
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied to the NFSD for-next branch.


> ---
> fs/nfsd/nfsctl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 0621c2faf242..66c352bf61b1 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -633,7 +633,6 @@ static ssize_t __write_versions(struct file *file, char *buf, size_t size)
> }
>
> /* Now write current state into reply buffer */
> - len = 0;
> sep = "";
> remaining = SIMPLE_TRANSACTION_LIMIT;
> for (num=2 ; num <= 4 ; num++) {
> --
> 2.35.3
>

--
Chuck Lever