2019-11-26 16:20:35

by Scott Mayhew

[permalink] [raw]
Subject: [nfs-utils PATCH 0/3] A few small nfsdcld fixes

The first two patches fix problems I noticed when trying to build an rpm
package w/ nfsdcld enabled. The third patch fixes an issue I found
trying to use nfsdcld on a ppc64le system.

Scott Mayhew (3):
nfsdcld: don't override sbindir
systemd: install nfsdcld.service when nfsdcld is enabled
nfsdcld: getopt_long() returns an int, not a char

systemd/Makefile.am | 5 +++++
utils/nfsdcld/Makefile.am | 4 ----
utils/nfsdcld/nfsdcld.c | 2 +-
3 files changed, 6 insertions(+), 5 deletions(-)

--
2.17.2


2019-11-26 16:20:58

by Scott Mayhew

[permalink] [raw]
Subject: [nfs-utils PATCH 1/3] nfsdcld: don't override sbindir

According to the guidelines in hier(7), nfsdcld should live in /usr/sbin
and not /sbin. Plus, the nfsdcld.service systemd unit file is looking
for it in /usr/sbin.

Signed-off-by: Scott Mayhew <[email protected]>
---
utils/nfsdcld/Makefile.am | 4 ----
1 file changed, 4 deletions(-)

diff --git a/utils/nfsdcld/Makefile.am b/utils/nfsdcld/Makefile.am
index 2c4e5a1..273d64f 100644
--- a/utils/nfsdcld/Makefile.am
+++ b/utils/nfsdcld/Makefile.am
@@ -1,9 +1,5 @@
## Process this file with automake to produce Makefile.in

-# These binaries go in /sbin (not /usr/sbin), and that cannot be
-# overridden at config time. The kernel "knows" the /sbin name.
-sbindir = /sbin
-
man8_MANS = nfsdcld.man
EXTRA_DIST = $(man8_MANS)

--
2.17.2

2019-12-09 15:58:14

by Steve Dickson

[permalink] [raw]
Subject: Re: [nfs-utils PATCH 0/3] A few small nfsdcld fixes



On 11/26/19 10:47 AM, Scott Mayhew wrote:
> The first two patches fix problems I noticed when trying to build an rpm
> package w/ nfsdcld enabled. The third patch fixes an issue I found
> trying to use nfsdcld on a ppc64le system.
>
> Scott Mayhew (3):
> nfsdcld: don't override sbindir
> systemd: install nfsdcld.service when nfsdcld is enabled
> nfsdcld: getopt_long() returns an int, not a char
>
> systemd/Makefile.am | 5 +++++
> utils/nfsdcld/Makefile.am | 4 ----
> utils/nfsdcld/nfsdcld.c | 2 +-
> 3 files changed, 6 insertions(+), 5 deletions(-)
>
Series committed... (tag: nfs-utils-2-4-3-rc3)

steved.