2017-10-06 02:48:11

by NeilBrown

[permalink] [raw]
Subject: [nfs-utils PATCH] Add RemainAfterExit to two services.


Both auth-rpcgss-module and rpc-statd-notify only
ever need to be run once - the effect they have
is permanent.
We can give this information to systemd by setting
RemainAfterExit=yes
This avoids the minor cost of running them a second time
if something "Wants" either service after it was first run,
(e.g. both client and server startup can Want these),
and avoids systemd complaining that it restarts to fast
if multiple Wants happen at nearly the same time.

Signed-off-by: NeilBrown <[email protected]>
---
systemd/auth-rpcgss-module.service | 1 +
systemd/rpc-statd-notify.service | 1 +
2 files changed, 2 insertions(+)

diff --git a/systemd/auth-rpcgss-module.service b/systemd/auth-rpcgss-module.service
index 5241f7b5d58e..4548283377d0 100644
--- a/systemd/auth-rpcgss-module.service
+++ b/systemd/auth-rpcgss-module.service
@@ -14,3 +14,4 @@ ConditionPathExists=/etc/krb5.keytab
[Service]
Type=oneshot
ExecStart=/sbin/modprobe -q auth_rpcgss
+RemainAfterExit=yes
diff --git a/systemd/rpc-statd-notify.service b/systemd/rpc-statd-notify.service
index 687fe31140c0..aad4c0d29efe 100644
--- a/systemd/rpc-statd-notify.service
+++ b/systemd/rpc-statd-notify.service
@@ -13,3 +13,4 @@ PartOf=nfs-utils.service
[Service]
Type=forking
ExecStart=-/usr/sbin/sm-notify
+RemainAfterExit=yes
--
2.14.0.rc0.dirty


Attachments:
signature.asc (832.00 B)

2017-10-12 14:20:47

by Steve Dickson

[permalink] [raw]
Subject: Re: [nfs-utils PATCH] Add RemainAfterExit to two services.



On 10/05/2017 10:48 PM, NeilBrown wrote:
>
> Both auth-rpcgss-module and rpc-statd-notify only
> ever need to be run once - the effect they have
> is permanent.
> We can give this information to systemd by setting
> RemainAfterExit=yes
> This avoids the minor cost of running them a second time
> if something "Wants" either service after it was first run,
> (e.g. both client and server startup can Want these),
> and avoids systemd complaining that it restarts to fast
> if multiple Wants happen at nearly the same time.
>
> Signed-off-by: NeilBrown <[email protected]>
Committed...

steved.
> ---
> systemd/auth-rpcgss-module.service | 1 +
> systemd/rpc-statd-notify.service | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/systemd/auth-rpcgss-module.service b/systemd/auth-rpcgss-module.service
> index 5241f7b5d58e..4548283377d0 100644
> --- a/systemd/auth-rpcgss-module.service
> +++ b/systemd/auth-rpcgss-module.service
> @@ -14,3 +14,4 @@ ConditionPathExists=/etc/krb5.keytab
> [Service]
> Type=oneshot
> ExecStart=/sbin/modprobe -q auth_rpcgss
> +RemainAfterExit=yes
> diff --git a/systemd/rpc-statd-notify.service b/systemd/rpc-statd-notify.service
> index 687fe31140c0..aad4c0d29efe 100644
> --- a/systemd/rpc-statd-notify.service
> +++ b/systemd/rpc-statd-notify.service
> @@ -13,3 +13,4 @@ PartOf=nfs-utils.service
> [Service]
> Type=forking
> ExecStart=-/usr/sbin/sm-notify
> +RemainAfterExit=yes
>