2020-08-25 21:55:15

by NeilBrown

[permalink] [raw]

Subject: [PATCH nfs-utils] Convert remaining python scripts to python3

---

nfs-utils contains 4 python scripts, two request
/usr/bin/python3
in their shebang line, two request
/usr/bin/python

Those latter two run perfectly well with python3 and as python2 is on the
way out, change them so they requrest /usr/bin/python3.

Signed-off-by: NeilBrown <[email protected]>
---
tools/mountstats/mountstats.py | 2 +-
tools/nfs-iostat/nfs-iostat.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index 1054f698c8e3..00adc96bafeb 100755
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/python3
# -*- python-mode -*-
"""Parse /proc/self/mountstats and display it in human readable form
"""
diff --git a/tools/nfs-iostat/nfs-iostat.py b/tools/nfs-iostat/nfs-iostat.py
index 5556f692b7ee..6e59837ee673 100755
--- a/tools/nfs-iostat/nfs-iostat.py
+++ b/tools/nfs-iostat/nfs-iostat.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/python3
# -*- python-mode -*-
"""Emulate iostat for NFS mount points using /proc/self/mountstats
"""
--
2.28.0

---

Attachments:

signature.asc (847.00 B)

2020-08-31 15:01:07

by Steve Dickson

[permalink] [raw]

Subject: Re: [PATCH nfs-utils] Convert remaining python scripts to python3

---

On 8/25/20 5:54 PM, NeilBrown wrote:
>
> nfs-utils contains 4 python scripts, two request
> /usr/bin/python3
> in their shebang line, two request
> /usr/bin/python
>
> Those latter two run perfectly well with python3 and as python2 is on the
> way out, change them so they requrest /usr/bin/python3.
>
> Signed-off-by: NeilBrown <[email protected]>
Committed... (tag: nfs-utils-2-5-2-rc4)

steved.
> ---
> tools/mountstats/mountstats.py | 2 +-
> tools/nfs-iostat/nfs-iostat.py | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
> index 1054f698c8e3..00adc96bafeb 100755
> --- a/tools/mountstats/mountstats.py
> +++ b/tools/mountstats/mountstats.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/python
> +#!/usr/bin/python3
> # -*- python-mode -*-
> """Parse /proc/self/mountstats and display it in human readable form
> """
> diff --git a/tools/nfs-iostat/nfs-iostat.py b/tools/nfs-iostat/nfs-iostat.py
> index 5556f692b7ee..6e59837ee673 100755
> --- a/tools/nfs-iostat/nfs-iostat.py
> +++ b/tools/nfs-iostat/nfs-iostat.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/python
> +#!/usr/bin/python3
> # -*- python-mode -*-
> """Emulate iostat for NFS mount points using /proc/self/mountstats
> """
>