2016-08-08 09:13:53

by Amitoj Kaur Chawla

Subject: [PATCH] sunrpc: Remove unnecessary variable

The variable `err` is not used anywhere and just returns the
predefined value `0` at the end of the function. Hence, remove the
variable and return 0 explicitly.

Signed-off-by: Amitoj Kaur Chawla <[email protected]>
---
net/sunrpc/clnt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index b7f2104..0a775fa 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -184,7 +184,6 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
struct super_block *sb)
{
struct dentry *dentry;
- int err = 0;

switch (event) {
case RPC_PIPEFS_MOUNT:
@@ -201,7 +200,7 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
printk(KERN_ERR "%s: unknown event: %ld\n", __func__, event);
return -ENOTSUPP;
}
- return err;
+ return 0;
}

static int __rpc_pipefs_event(struct rpc_clnt *clnt, unsigned long event,
--
1.9.1

2016-08-08 13:50:03

by Anna Schumaker

Subject: Re: [PATCH] sunrpc: Remove unnecessary variable

On 08/08/2016 05:13 AM, Amitoj Kaur Chawla wrote:
> The variable `err` is not used anywhere and just returns the
> predefined value `0` at the end of the function. Hence, remove the
> variable and return 0 explicitly.

Makes sense to me. Thanks!

Anna

>
> Signed-off-by: Amitoj Kaur Chawla <[email protected]>
> ---
> net/sunrpc/clnt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index b7f2104..0a775fa 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -184,7 +184,6 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
> struct super_block *sb)
> {
> struct dentry *dentry;
> - int err = 0;
>
> switch (event) {
> case RPC_PIPEFS_MOUNT:
> @@ -201,7 +200,7 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
> printk(KERN_ERR "%s: unknown event: %ld\n", __func__, event);
> return -ENOTSUPP;
> }
> - return err;
> + return 0;
> }
>
> static int __rpc_pipefs_event(struct rpc_clnt *clnt, unsigned long event,
>