> -----Original Message-----
> From: Myklebust, Trond
> Sent: Monday, August 24, 2009 4:42 PM
> To: J. Bruce Fields
> Cc: Benny Halevy; [email protected]; [email protected]; Iyer,
> Rahul; Sager, Mike; Marc Eshel; Labiaga, Ricardo; Adamson, Andy;
> Batsakis, Alexandros; Myklebust, Trond
> Subject: Re: [PATCH RFC 02/10] nfsd41: sunrpc: Added rpc server-side
> backchannel handling
>
> > >
> > > When the call direction is a reply, copy the xid and call
direction
> into the
> > > req->rq_private_buf.head[0].iov_base otherwise rpc_verify_header
> returns
> > > rpc_garbage.
> >
> > Looks mostly OK, though blocking the client rpciod on the
> > bc_send_request method may be a problem--rpciod normally tries not
to
> > sleep, and the other send_request methods look like they avoid it.
>
> Agreed. Blocking on sending is unacceptable inside rpciod. Please
> either
> use non-blocking I/O, or use a different thread context for this.
>
OK thanks, it makes sense. I ll take care of it
-alexandros
>
> --
> Trond Myklebust
> Linux NFS client maintainer
>
> NetApp
> [email protected]
> http://www.netapp.com