2024-01-26 13:49:34

by Chuck Lever III

[permalink] [raw]
Subject: Re: [PATCH v2 05/13] sunrpc: add a struct rpc_stats arg to rpc_create_args



> On Jan 25, 2024, at 4:54 PM, Josef Bacik <[email protected]> wrote:
>
> On Thu, Jan 25, 2024 at 03:53:24PM -0500, Chuck Lever wrote:
>> On Thu, Jan 25, 2024 at 02:53:15PM -0500, Josef Bacik wrote:
>>> We want to be able to have our rpc stats handled in a per network
>>> namespace manner, so add an option to rpc_create_args to specify a
>>> different rpc_stats struct instead of using the one on the rpc_program.
>>>
>>> Signed-off-by: Josef Bacik <[email protected]>
>>> ---
>>> fs/nfs/client.c | 2 +-
>>> include/linux/sunrpc/clnt.h | 1 +
>>> net/sunrpc/clnt.c | 2 +-
>>> 3 files changed, 3 insertions(+), 2 deletions(-)
>>
>> I know it isn't obvious to an outside observer, but the
>> maintainership of the NFS server and client are separate.
>>
>> NFS client patches go To: Trond and Anna, Cc: linux-nfs
>>
>> NFS server patches go To: Jeff and Chuck, Cc: linux-nfs
>>
>> and you can Cc: server patches on the reviewers listed in
>> MAINTAINERS too if you like.
>
> Sounds good, should I split the series up completely? I think the nfsd and nfs
> sunrpc related changes are unique to either stack

That's what it looks like to me too.


> so I can split it out into two different series if that would help.

Let's do that for v3.

--
Chuck Lever