2013-04-05 13:22:40

by Wei Yongjun

Subject: [PATCH -next] nfsd: make symbol nfsd_reply_cache_shrinker static

From: Wei Yongjun <[email protected]>

symbol 'nfsd_reply_cache_shrinker' only used within this file. It should
be static.

Signed-off-by: Wei Yongjun <[email protected]>
---
fs/nfsd/nfscache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfscache.c b/fs/nfsd/nfscache.c
index f8bb605..890a507 100644
--- a/fs/nfsd/nfscache.c
+++ b/fs/nfsd/nfscache.c
@@ -56,7 +56,7 @@ static void cache_cleaner_func(struct work_struct *unused);
static int nfsd_reply_cache_shrink(struct shrinker *shrink,
struct shrink_control *sc);

-struct shrinker nfsd_reply_cache_shrinker = {
+static struct shrinker nfsd_reply_cache_shrinker = {
.shrink = nfsd_reply_cache_shrink,
.seeks = 1,
};

2013-04-30 22:20:18

by J. Bruce Fields

Subject: Re: [PATCH -next] nfsd: make symbol nfsd_reply_cache_shrinker static

Applying, thanks.--b.

On Fri, Apr 05, 2013 at 09:22:39PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> symbol 'nfsd_reply_cache_shrinker' only used within this file. It should
> be static.
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> fs/nfsd/nfscache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfscache.c b/fs/nfsd/nfscache.c
> index f8bb605..890a507 100644
> --- a/fs/nfsd/nfscache.c
> +++ b/fs/nfsd/nfscache.c
> @@ -56,7 +56,7 @@ static void cache_cleaner_func(struct work_struct *unused);
> static int nfsd_reply_cache_shrink(struct shrinker *shrink,
> struct shrink_control *sc);
>
> -struct shrinker nfsd_reply_cache_shrinker = {
> +static struct shrinker nfsd_reply_cache_shrinker = {
> .shrink = nfsd_reply_cache_shrink,
> .seeks = 1,
> };
>