2013-04-09 06:15:33

by Wei Yongjun

Subject: [PATCH] nfsd: use kmem_cache_free() instead of kfree()

From: Wei Yongjun <[email protected]>

memory allocated by kmem_cache_alloc() should be freed using
kmem_cache_free(), not kfree().

Signed-off-by: Wei Yongjun <[email protected]>
---
fs/nfsd/nfs4state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 2e27430..06a520b 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -267,7 +267,7 @@ kmem_cache *slab)
min_stateid = 0;
return stid;
out_free:
- kfree(stid);
+ kmem_cache_free(slab, stid);
return NULL;
}

2013-04-09 13:09:19

by J. Bruce Fields

Subject: Re: [PATCH] nfsd: use kmem_cache_free() instead of kfree()

On Tue, Apr 09, 2013 at 02:15:31PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> memory allocated by kmem_cache_alloc() should be freed using
> kmem_cache_free(), not kfree().

Applying, thanks.--b.

>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 2e27430..06a520b 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -267,7 +267,7 @@ kmem_cache *slab)
> min_stateid = 0;
> return stid;
> out_free:
> - kfree(stid);
> + kmem_cache_free(slab, stid);
> return NULL;
> }
>
>