2012-12-01 05:55:02

by Marc Eshel

Subject: notify_deviceid_type4

The spec defines notify_deviceid_type4 as:

20.12.1. ARGUMENT
/*
* Device notification types.
*/
enum notify_deviceid_type4 {
NOTIFY_DEVICEID4_CHANGE = 1,
NOTIFY_DEVICEID4_DELETE = 2
};


but the Linux code in nfs4.h has, is that going to be fixed?

enum pnfs_notify_deviceid_type4 {
NOTIFY_DEVICEID4_CHANGE = 1 << 1,
NOTIFY_DEVICEID4_DELETE = 1 << 2,
};

2012-12-09 16:43:59

by Marc Eshel

Subject: Re: notify_deviceid_type4

I am not sure what you are saying, I am showing the definition from the
spec. that show NOTIFY_DEVICEID4_CHANGE = 1, and nfs4.h has it as (1<< 1)
which is not 1, it is 2.
Marc.

Benny Halevy <[email protected]> wrote on 12/09/2012 01:42:47 AM:

> From: Benny Halevy <[email protected]>
> To: Marc Eshel/Almaden/IBM@IBMUS,
> Cc: Trond Myklebust <[email protected]>, "J. Bruce Fields"
> <[email protected]>, [email protected], linux-
> [email protected]
> Date: 12/09/2012 01:44 AM
> Subject: Re: notify_deviceid_type4
>
> On 2012-12-01 07:54, Marc Eshel wrote:
> > The spec defines notify_deviceid_type4 as:
> >
> > 20.12.1. ARGUMENT
> > /*
> > * Device notification types.
> > */
> > enum notify_deviceid_type4 {
> > NOTIFY_DEVICEID4_CHANGE = 1,
> > NOTIFY_DEVICEID4_DELETE = 2
> > };
> >
> >
> > but the Linux code in nfs4.h has, is that going to be fixed?
> >
> > enum pnfs_notify_deviceid_type4 {
> > NOTIFY_DEVICEID4_CHANGE = 1 << 1,
> > NOTIFY_DEVICEID4_DELETE = 1 << 2,
> > };
>
> notify_deviceid_type4 specifies bit numbers same as notify_type4
> It seems to me like the definition in nfs4.h is correct.
>
> Benny
>
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nfs"
in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>

2012-12-09 09:42:52

by Benny Halevy

Subject: Re: notify_deviceid_type4

On 2012-12-01 07:54, Marc Eshel wrote:
> The spec defines notify_deviceid_type4 as:
>
> 20.12.1. ARGUMENT
> /*
> * Device notification types.
> */
> enum notify_deviceid_type4 {
> NOTIFY_DEVICEID4_CHANGE = 1,
> NOTIFY_DEVICEID4_DELETE = 2
> };
>
>
> but the Linux code in nfs4.h has, is that going to be fixed?
>
> enum pnfs_notify_deviceid_type4 {
> NOTIFY_DEVICEID4_CHANGE = 1 << 1,
> NOTIFY_DEVICEID4_DELETE = 1 << 2,
> };

notify_deviceid_type4 specifies bit numbers same as notify_type4
It seems to me like the definition in nfs4.h is correct.

Benny

>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>