2012-12-07 23:46:16

by Marc Eshel

[permalink] [raw]
Subject: Re: notify_deviceid_type4

Trond, can you please apply the following patch so we are in compliance
with the spec.
Thanks, Marc.

diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h
index 59cc833..ad32df5 100644
--- a/include/linux/nfs4.h
+++ b/include/linux/nfs4.h
@@ -499,8 +499,8 @@ enum pnfs_iomode {
};

enum pnfs_notify_deviceid_type4 {
- NOTIFY_DEVICEID4_CHANGE = 1 << 1,
- NOTIFY_DEVICEID4_DELETE = 1 << 2,
+ NOTIFY_DEVICEID4_CHANGE = 1,
+ NOTIFY_DEVICEID4_DELETE = 2,
};

#define NFL4_UFLG_MASK 0x0000003F

-------------------------------------------------------------------------------------------------------------

The spec defines notify_deviceid_type4 as:

20.12.1. ARGUMENT
/*
* Device notification types.
*/
enum notify_deviceid_type4 {
NOTIFY_DEVICEID4_CHANGE = 1,
NOTIFY_DEVICEID4_DELETE = 2
};