2008-05-20 13:27:47

by Talpey, Thomas

[permalink] [raw]
Subject: Re: [PATCH 01/05] svcrdma: Verify read-list fits within RPCSVC_MAXPAGES

At 09:07 PM 5/19/2008, Tom Tucker wrote:
>No we don't and a Byzantine client could crash us.

That can be arranged... :-)

>This kind of check along with a bunch of others should go in
>svc_rdma_xdr_decode_req. I have these things planned for the 2.6.27
>time-frame (along with Fast NSMR support).
>
>Do you think it's more urgent?

MHO is that it's important but not urgent, and it should be part of a later
change. At Connectathon, no clients were sending any problematic requests,
so I think it's unlikely this will affect us in the wild, for now.

Tom.