LinuxLists.cc - [RFC PATCH 0/3] Remove RPC rup and rusers tests

2022-04-28 17:24:45

Subject: [RFC PATCH 0/3] Remove RPC rup and rusers tests

Hi all,

IMHO safe to remove these two tests, but sending to broad audience in
case anybody really want to have these 2 kept (they'd be rewritten to
new LTP shell API).

BTW in long term I'd prefer to remove all RPC tests
(testcases/network/rpc/ directory). IMHO they should be part of libtirpc
(which has no tests), but these tests are old, messy and I'm not sure
how relevant they are nowadays.

Kind regards,
Petr

Petr Vorel (3):
rpc: Remove rup01.sh test
rpc: Remove rusers01.sh test
rpc: Move rest of RPC tests to runtest/net.rpc_tests

runtest/net.rpc | 8 ---
runtest/net.rpc_tests | 3 ++
scenario_groups/network | 1 -
.../network/rpc/basic_tests/rup/Makefile | 29 -----------
.../network/rpc/basic_tests/rup/rup01.sh | 50 -------------------
.../network/rpc/basic_tests/rusers/Makefile | 29 -----------
.../rpc/basic_tests/rusers/rusers01.sh | 50 -------------------
testscripts/network.sh | 4 +-
8 files changed, 4 insertions(+), 170 deletions(-)
delete mode 100644 runtest/net.rpc
delete mode 100644 testcases/network/rpc/basic_tests/rup/Makefile
delete mode 100755 testcases/network/rpc/basic_tests/rup/rup01.sh
delete mode 100644 testcases/network/rpc/basic_tests/rusers/Makefile
delete mode 100755 testcases/network/rpc/basic_tests/rusers/rusers01.sh

--
2.35.3

2022-04-28 21:29:25

by Petr Vorel

[permalink] [raw]

Subject: [RFC PATCH 2/3] rpc: Remove rusers01.sh test

rusersd is a RPC daemon which returns information about users currently
logged in to the system. It uses rusers on client side.

Latest release of netkit-rusers 0.17 was in 2001. Although it's still
installable on Debian, IMHO whole technology is not used nowadays.

As we have other RPC tests (both RPC/TI-RPC and RPC integration, i.e.
NFS), we don't need to test this particular implementation. If this
implementation is really useful, it should be moved into libtirpc
project.

Signed-off-by: Petr Vorel <[email protected]>
---
runtest/net.rpc | 1 -
.../network/rpc/basic_tests/rusers/Makefile | 29 -----------
.../rpc/basic_tests/rusers/rusers01.sh | 50 -------------------
3 files changed, 80 deletions(-)
delete mode 100644 testcases/network/rpc/basic_tests/rusers/Makefile
delete mode 100755 testcases/network/rpc/basic_tests/rusers/rusers01.sh

diff --git a/runtest/net.rpc b/runtest/net.rpc
index ccee1dda7..d2cec5b93 100644
--- a/runtest/net.rpc
+++ b/runtest/net.rpc
@@ -4,4 +4,3 @@
#
rpc01 rpc01.sh
rpcinfo rpcinfo01.sh
-rusers rusers01.sh
diff --git a/testcases/network/rpc/basic_tests/rusers/Makefile b/testcases/network/rpc/basic_tests/rusers/Makefile
deleted file mode 100644
index 345365171..000000000
--- a/testcases/network/rpc/basic_tests/rusers/Makefile
+++ /dev/null
@@ -1,29 +0,0 @@
-#
-# network/rpc/basic_tests/rusers01.sh test suite Makefile.
-#
-# Copyright (C) 2009, Cisco Systems Inc.
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License along
-# with this program; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-# Ngie Cooper, July 2009
-#
-
-top_srcdir ?= ../../../../..
-
-include $(top_srcdir)/include/mk/env_pre.mk
-
-INSTALL_TARGETS := rusers01.sh
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/network/rpc/basic_tests/rusers/rusers01.sh b/testcases/network/rpc/basic_tests/rusers/rusers01.sh
deleted file mode 100755
index 554bfa01c..000000000
--- a/testcases/network/rpc/basic_tests/rusers/rusers01.sh
+++ /dev/null
@@ -1,50 +0,0 @@
-#!/bin/sh
-# Copyright (c) 2017 Oracle and/or its affiliates. All Rights Reserved.
-# Copyright (c) International Business Machines Corp., 2000
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it would be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-TCID="rusers01"
-TST_TOTAL=5
-
-TST_USE_LEGACY_API=1
-. tst_net.sh
-
-do_setup()
-{
- tst_resm TINFO "Checking for rusersd on $(tst_ipaddr)"
- rpcinfo -u $(tst_ipaddr) rusersd > /dev/null 2>&1 || \
- tst_brkm TCONF "rusersd is inactive on $(tst_ipaddr)"
-}
-
-do_test()
-{
- tst_resm TINFO "Test rusers with options set"
-
- EXPECT_RHOST_PASS rusers $(tst_ipaddr)
-
- local opts="-a -l"
- for opt in $opts; do
- EXPECT_RHOST_PASS rusers $opt $(tst_ipaddr)
- done
-
- tst_resm TINFO "Test rusers with bad options"
- EXPECT_RHOST_FAIL rusers bogushost
- EXPECT_RHOST_FAIL rusers -bogusflag $(tst_ipaddr)
-}
-
-do_setup
-do_test
-
-tst_exit
--
2.35.3

2022-04-29 05:34:16

by Petr Vorel

[permalink] [raw]

Subject: [RFC PATCH 3/3] rpc: Move rest of RPC tests to runtest/net.rpc_tests

It does not make much sense to keep just 2 tests in separate
runtest file.

Signed-off-by: Petr Vorel <[email protected]>
---
runtest/net.rpc | 6 ------
runtest/net.rpc_tests | 3 +++
scenario_groups/network | 1 -
testscripts/network.sh | 4 +---
4 files changed, 4 insertions(+), 10 deletions(-)
delete mode 100644 runtest/net.rpc

diff --git a/runtest/net.rpc b/runtest/net.rpc
deleted file mode 100644
index d2cec5b93..000000000
--- a/runtest/net.rpc
+++ /dev/null
@@ -1,6 +0,0 @@
-#DESCRIPTION:Remote Procedure Call
-#
-# PLEASE READ THE README FILE IN /rpc BEFORE RUNNING THESE.
-#
-rpc01 rpc01.sh
-rpcinfo rpcinfo01.sh
diff --git a/runtest/net.rpc_tests b/runtest/net.rpc_tests
index 84c296027..25d219dce 100644
--- a/runtest/net.rpc_tests
+++ b/runtest/net.rpc_tests
@@ -1,3 +1,6 @@
+rpc01 rpc01.sh
+rpcinfo rpcinfo01.sh
+
rpc_pmap_set rpc_test.sh -c rpc_pmap_set
rpc_pmap_unset rpc_test.sh -c rpc_pmap_unset
rpc_pmap_getport rpc_test.sh -s rpc_svc_1 -c rpc_pmap_getport
diff --git a/scenario_groups/network b/scenario_groups/network
index 46829501f..974b9fc58 100644
--- a/scenario_groups/network
+++ b/scenario_groups/network
@@ -4,7 +4,6 @@ net.ipv6
net.ipv6_lib
net.tcp_cmds
net.multicast
-net.rpc
net.nfs
net.rpc_tests
net.tirpc_tests
diff --git a/testscripts/network.sh b/testscripts/network.sh
index 5cfeee844..15a4cc1c7 100755
--- a/testscripts/network.sh
+++ b/testscripts/network.sh
@@ -26,10 +26,9 @@ usage()
echo " -6 IPv6 tests"
echo " -m multicast tests"
echo " -n NFS tests"
- echo " -r RPC tests"
echo " -s SCTP tests"
echo " -t TCP/IP command tests"
- echo " -c TI-RPC tests"
+ echo " -c RPC and TI-RPC tests"
echo " -d TS-RPC tests"
echo " -a Application stress tests (HTTP, SSH, DNS)"
echo " -e Interface stress tests"
@@ -56,7 +55,6 @@ do
6) TEST_CASES="$TEST_CASES net.ipv6 net.ipv6_lib";;
m) TEST_CASES="$TEST_CASES net.multicast";;
n) TEST_CASES="$TEST_CASES net.nfs";;
- r) TEST_CASES="$TEST_CASES net.rpc";;
s) TEST_CASES="$TEST_CASES net.sctp";;
t) TEST_CASES="$TEST_CASES net.tcp_cmds";;
c) TEST_CASES="$TEST_CASES net.rpc_tests";;
--
2.35.3

2022-04-29 09:43:33

by Petr Vorel

[permalink] [raw]

Subject: Re: [RFC PATCH 0/3] Remove RPC rup and rusers tests

Hi all,

I'm sorry, I again used the old mail address of automated-testing ML.
Please have look at this patchset:

https://lore.kernel.org/ltp/[email protected]/
https://patchwork.ozlabs.org/project/ltp/list/?series=297407&state=*

Kind regards,
Petr

> Hi all,

> IMHO safe to remove these two tests, but sending to broad audience in
> case anybody really want to have these 2 kept (they'd be rewritten to
> new LTP shell API).

> BTW in long term I'd prefer to remove all RPC tests
> (testcases/network/rpc/ directory). IMHO they should be part of libtirpc
> (which has no tests), but these tests are old, messy and I'm not sure
> how relevant they are nowadays.

> Kind regards,
> Petr

> Petr Vorel (3):
> rpc: Remove rup01.sh test
> rpc: Remove rusers01.sh test
> rpc: Move rest of RPC tests to runtest/net.rpc_tests

> runtest/net.rpc | 8 ---
> runtest/net.rpc_tests | 3 ++
> scenario_groups/network | 1 -
> .../network/rpc/basic_tests/rup/Makefile | 29 -----------
> .../network/rpc/basic_tests/rup/rup01.sh | 50 -------------------
> .../network/rpc/basic_tests/rusers/Makefile | 29 -----------
> .../rpc/basic_tests/rusers/rusers01.sh | 50 -------------------
> testscripts/network.sh | 4 +-
> 8 files changed, 4 insertions(+), 170 deletions(-)
> delete mode 100644 runtest/net.rpc
> delete mode 100644 testcases/network/rpc/basic_tests/rup/Makefile
> delete mode 100755 testcases/network/rpc/basic_tests/rup/rup01.sh
> delete mode 100644 testcases/network/rpc/basic_tests/rusers/Makefile
> delete mode 100755 testcases/network/rpc/basic_tests/rusers/rusers01.sh