2019-08-28 07:12:24

by Patrick Steinhardt

Subject: [PATCH 0/6] Fixes for various compiler warnings

Hi,

here's some assorted fixes for compiler warnings I'm seeing on my
platform. Most warnings are probably due to using musl libc, but
the fixes should be the correct thing to do regardless. With this
patchset, I can now compile nfs-utils with -Werror just fine.

Regards
Patrick

Patrick Steinhardt (6):
Annotate unused fields with UNUSED
Use <fcntl.h> header instead of <sys/fcntl.h>
Use <poll.h> header instead of <sys/poll.h>
configure.ac: Add <sys/socket.h> header when checking
sizeof(socklen_t)
nfsd_path: Include missing header for `struct stat`
mountd: Use unsigned for filesystem type magic constants

configure.ac | 5 ++++-
support/export/xtab.c | 2 +-
support/include/nfsd_path.h | 2 ++
support/misc/xstat.c | 3 ++-
support/nfs/rmtab.c | 2 +-
support/nfs/rpc_socket.c | 3 ++-
support/nfs/svc_socket.c | 2 +-
support/nfs/xio.c | 2 +-
utils/gssd/svcgssd_main_loop.c | 2 +-
utils/mountd/cache.c | 4 ++--
utils/statd/sm-notify.c | 2 +-
11 files changed, 18 insertions(+), 11 deletions(-)

--
2.23.0

2019-09-05 13:31:07

by Steve Dickson

Subject: Re: [PATCH 0/6] Fixes for various compiler warnings

On 8/28/19 3:10 AM, Patrick Steinhardt wrote:
> Hi,
>
> here's some assorted fixes for compiler warnings I'm seeing on my
> platform. Most warnings are probably due to using musl libc, but
> the fixes should be the correct thing to do regardless. With this
> patchset, I can now compile nfs-utils with -Werror just fine.
Patchset committed....

steved.
>
> Regards
> Patrick
>
> Patrick Steinhardt (6):
> Annotate unused fields with UNUSED
> Use <fcntl.h> header instead of <sys/fcntl.h>
> Use <poll.h> header instead of <sys/poll.h>
> configure.ac: Add <sys/socket.h> header when checking
> sizeof(socklen_t)
> nfsd_path: Include missing header for `struct stat`
> mountd: Use unsigned for filesystem type magic constants
>
> configure.ac | 5 ++++-
> support/export/xtab.c | 2 +-
> support/include/nfsd_path.h | 2 ++
> support/misc/xstat.c | 3 ++-
> support/nfs/rmtab.c | 2 +-
> support/nfs/rpc_socket.c | 3 ++-
> support/nfs/svc_socket.c | 2 +-
> support/nfs/xio.c | 2 +-
> utils/gssd/svcgssd_main_loop.c | 2 +-
> utils/mountd/cache.c | 4 ++--
> utils/statd/sm-notify.c | 2 +-
> 11 files changed, 18 insertions(+), 11 deletions(-)
>