2017-01-19 08:37:57

by Kinglong Mee

Subject: [PATCH v2 1/2] NFSv4.x/callback: Create the callback service through svc_create_pooled

As the comments for svc_set_num_threads() said,
" Destroying threads relies on the service threads filling in
rqstp->rq_task, which only the nfs ones do. Assumes the serv
has been created using svc_create_pooled()."

If creating service through svc_create(), the svc_pool_map_put()
will be called in svc_destroy(), but the pool map isn't used.
So that, the reference of pool map will be drop, the next using
of pool map will get a zero npools.

Signed-off-by: Kinglong Mee <[email protected]>
---
fs/nfs/callback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
index 484bebc..0a21150 100644
--- a/fs/nfs/callback.c
+++ b/fs/nfs/callback.c
@@ -279,7 +279,7 @@ static struct svc_serv *nfs_callback_create_svc(int minorversion)
printk(KERN_WARNING "nfs_callback_create_svc: no kthread, %d users??\n",
cb_info->users);

- serv = svc_create(&nfs4_callback_program, NFS4_CALLBACK_BUFSIZE, sv_ops);
+ serv = svc_create_pooled(&nfs4_callback_program, NFS4_CALLBACK_BUFSIZE, sv_ops);
if (!serv) {
printk(KERN_ERR "nfs_callback_create_svc: create service failed\n");
return ERR_PTR(-ENOMEM);
--
2.9.3

2017-03-03 16:37:49

by Kinglong Mee

Subject: Re: [PATCH v2 1/2] NFSv4.x/callback: Create the callback service through svc_create_pooled

Ping...

The state?

thanks,
Kinglong Mee

On 1/19/2017 16:36, Kinglong Mee wrote:
> As the comments for svc_set_num_threads() said,
> " Destroying threads relies on the service threads filling in
> rqstp->rq_task, which only the nfs ones do. Assumes the serv
> has been created using svc_create_pooled()."
>
> If creating service through svc_create(), the svc_pool_map_put()
> will be called in svc_destroy(), but the pool map isn't used.
> So that, the reference of pool map will be drop, the next using
> of pool map will get a zero npools.
>
> Signed-off-by: Kinglong Mee <[email protected]>
> ---
> fs/nfs/callback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
> index 484bebc..0a21150 100644
> --- a/fs/nfs/callback.c
> +++ b/fs/nfs/callback.c
> @@ -279,7 +279,7 @@ static struct svc_serv *nfs_callback_create_svc(int minorversion)
> printk(KERN_WARNING "nfs_callback_create_svc: no kthread, %d users??\n",
> cb_info->users);
>
> - serv = svc_create(&nfs4_callback_program, NFS4_CALLBACK_BUFSIZE, sv_ops);
> + serv = svc_create_pooled(&nfs4_callback_program, NFS4_CALLBACK_BUFSIZE, sv_ops);
> if (!serv) {
> printk(KERN_ERR "nfs_callback_create_svc: create service failed\n");
> return ERR_PTR(-ENOMEM);
>

2017-04-24 12:18:38

by Benjamin Coddington

Subject: Re: [PATCH v2 1/2] NFSv4.x/callback: Create the callback service through svc_create_pooled

On Thu, 19 Jan 2017, Kinglong Mee wrote:

> As the comments for svc_set_num_threads() said,
> " Destroying threads relies on the service threads filling in
> rqstp->rq_task, which only the nfs ones do. Assumes the serv
> has been created using svc_create_pooled()."
>
> If creating service through svc_create(), the svc_pool_map_put()
> will be called in svc_destroy(), but the pool map isn't used.
> So that, the reference of pool map will be drop, the next using
> of pool map will get a zero npools.
>
> Signed-off-by: Kinglong Mee <[email protected]>

Thanks!

Reviewed-by: Benjamin Coddington <[email protected]>
Tested-by: Benjamin Coddington <[email protected]>

Ben

> ---
> fs/nfs/callback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
> index 484bebc..0a21150 100644
> --- a/fs/nfs/callback.c
> +++ b/fs/nfs/callback.c
> @@ -279,7 +279,7 @@ static struct svc_serv *nfs_callback_create_svc(int minorversion)
> printk(KERN_WARNING "nfs_callback_create_svc: no kthread, %d users??\n",
> cb_info->users);
>
> - serv = svc_create(&nfs4_callback_program, NFS4_CALLBACK_BUFSIZE, sv_ops);
> + serv = svc_create_pooled(&nfs4_callback_program, NFS4_CALLBACK_BUFSIZE, sv_ops);
> if (!serv) {
> printk(KERN_ERR "nfs_callback_create_svc: create service failed\n");
> return ERR_PTR(-ENOMEM);
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>