2020-04-24 18:40:47

by Tom Stellard

[permalink] [raw]
Subject: [PATCH 1/2] Fix -Wformat-nonliteral warning

xcommon.c:101:24: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
vfprintf (stderr, fmt2, args);
^~~~
---
support/nfs/xcommon.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/support/nfs/xcommon.c b/support/nfs/xcommon.c
index 3989f0bc..1d04dd11 100644
--- a/support/nfs/xcommon.c
+++ b/support/nfs/xcommon.c
@@ -94,13 +94,11 @@ xstrconcat4 (const char *s, const char *t, const char *u, const char *v) {
void
nfs_error (const char *fmt, ...) {
va_list args;
- char *fmt2;

- fmt2 = xstrconcat2 (fmt, "\n");
va_start (args, fmt);
- vfprintf (stderr, fmt2, args);
+ vfprintf (stderr, fmt, args);
+ fprintf (stderr, "\n");
va_end (args);
- free (fmt2);
}

/* Make a canonical pathname from PATH. Returns a freshly malloced string.
--
2.25.3