2022-10-10 20:27:15

by Colin Ian King

Subject: [PATCH] NFSD: Remove redundant assignment to variable host_err

Variable host_err is assigned a value that is never read, it is being
re-assigned a value in every different execution path in the following
switch statement. The assignment is redundant and can be removed.

Cleans up clang-scan warning:
warning: Value stored to 'host_err' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
fs/nfsd/vfs.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index f650afedd67f..5093ae788f53 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -1304,7 +1304,6 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct svc_fh *fhp,
iap->ia_mode &= ~current_umask();

err = 0;
- host_err = 0;
switch (type) {
case S_IFREG:
host_err = vfs_create(&init_user_ns, dirp, dchild, iap->ia_mode, true);
--
2.37.3

2022-10-11 14:11:17

by Chuck Lever III

Subject: Re: [PATCH] NFSD: Remove redundant assignment to variable host_err

> On Oct 10, 2022, at 4:24 PM, Colin Ian King <[email protected]> wrote:
>
> Variable host_err is assigned a value that is never read, it is being
> re-assigned a value in every different execution path in the following
> switch statement. The assignment is redundant and can be removed.
>
> Cleans up clang-scan warning:
> warning: Value stored to 'host_err' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>

Applying this for nfsd's for-next (not yet public). Thanks!



> ---
> fs/nfsd/vfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index f650afedd67f..5093ae788f53 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -1304,7 +1304,6 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct svc_fh *fhp,
> iap->ia_mode &= ~current_umask();
>
> err = 0;
> - host_err = 0;
> switch (type) {
> case S_IFREG:
> host_err = vfs_create(&init_user_ns, dirp, dchild, iap->ia_mode, true);
> --
> 2.37.3
>

--
Chuck Lever