2008-11-03 01:15:19

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] Patch to correct SBC gain mismatch and to test the encoding performance

Hi Christian,

>> So what is wrong with using sbctester program?
>
> The sbctester program is fine with me. Of course, I will do some
> indeed
> tests with PEAQ and I will complain until every things works
> perfect ;-)

yes please. Keep sending patches so we get the SBC encoder and decoder
passing the SBC conformance tests. I do prefer if we base it around
sbctester program so that we have a full open source solution (besides
the reference encoder/decoder).

Regards

Marcel


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2008-11-02 15:50:09

by Christian Hoene

[permalink] [raw]
Subject: Re: [Bluez-devel] Patch to correct SBC gain mismatch and to test the encoding performance

Hello Marcel,

> it would be nice if you just follow our coding style conventions. I
> fixed this up for you this time. Please compare the result that I
> pushed to the repository and your version.

Sorry, next time I will read the document beforehand.

> So what is wrong with using sbctester program?

The sbctester program is fine with me. Of course, I will do some indeed
tests with PEAQ and I will complain until every things works perfect ;-)

Regards,
Christian


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2008-10-31 23:18:34

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] Patch to correct SBC gain mismatch and to test the encoding performance

Hi Christian,

> attached you will find a patch to correct the following issues.
>
> 1.) Gain of the decoder is corrected (before it was 6.02dB or twice
> too low)
> 2.) Gain of the encoder is corrected (empirical gathered values were
> used to
> correct the filter tables)
> 3.) "sbcenc" supports more command line options.

it would be nice if you just follow our coding style conventions. I
fixed this up for you this time. Please compare the result that I
pushed to the repository and your version.

> 4.) A testing procedure for SBC is added including a script to test
> and a
> remote interface to PEAQ. It requires the reference version of SBC
> (available at the Bluetooth SIG website) and wine. Please note, that
> the
> remote access to PEAQ is restricted and only available by request
> for a
> limited time. Requesty from all unknown IP addresses are blocked by
> default.

So what is wrong with using sbctester program?

Regards

Marcel


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel