2004-02-02 19:25:05

by Fredrik Noring

[permalink] [raw]
Subject: [PATCH] DBus in hcid

Hi

This patch implements DBus in hcid. A simple interface for keytab is
available. It's possible to list and delete links (key pairs).

It's highly experimental. Only root is currently permitted access to
the DBus. There seem to be serious memory related issues which are not
resolved especially when hcid exists (double frees or similar). I
haven't figured out yet if this is due to hcid or DBus, because it's
DBus that crashes. I've run Valgrind and dmalloc on it.

The hcid DBus is currently available through the socket /tmp/dbus-hcid.
I think the system DBus ought to be connected as well. Next I'll look
into more cleanups, improved interfaces etc.

Marcel, I'm not planning on doing work on the Bluetooth library any
time soon. But I think your ideas for it are excellent. I'll concentrate
on fixing hcid.

Fredrik

configure.in | 5
hcid/Makefile.am | 9 -
hcid/dbus.c | 405 +++++++++++++++++++++++++++++++++++++++++++++++++++++
hcid/dbus.h | 32 ++++
hcid/glib-ectomy.c | 171 ----------------------
hcid/glib-ectomy.h | 106 -------------
hcid/hcid.h | 9 -
hcid/keytab.c | 119 +++++++++++++++
hcid/keytab.h | 4
hcid/main.c | 84 ++++++----
hcid/security.c | 78 ++++++----
hcid/watch.c | 289 +++++++++++++++++++++++++++++++++++++
hcid/watch.h | 75 +++++++++
13 files changed, 1029 insertions(+), 357 deletions(-)


Attachments:
hcid-dbus.2004-02-02.patch (40.19 kB)

2004-02-02 22:36:50

by Fredrik Noring

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] DBus in hcid

m?n 2004-02-02 klockan 20.25 skrev Fredrik Noring:
> There seem to be serious memory related issues which are not
> resolved especially when hcid exists (double frees or similar).

This patch fixes the memory issues and implements a hcid exit
registration mechanism.

Fredrik


Attachments:
hcid-dbus-fixes.2004-02-02.patch (9.43 kB)

2004-02-02 19:36:18

by Fredrik Noring

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] DBus in hcid

Hi

m?n 2004-02-02 klockan 20.25 skrev Fredrik Noring:
> This patch implements DBus in hcid. A simple interface for keytab is
> available. It's possible to list and delete links (key pairs).

This patch is more a proof-of-concept than a realistic implementation
but it does show an example of the hcid DBus by hcitool. Sample session:

# hcitool link list
00:10:DC:E9:EF:20 00:80:37:AA:7A:DA
00:10:DC:E9:EF:20 00:01:EC:0C:D2:00
# hcitool link delete 00:10:DC:E9:EF:20 00:80:37:AA:7A:DA
# hcitool link list
00:10:DC:E9:EF:20 00:01:EC:0C:D2:00

A proper hcid name cache interface will of course make it a lot easier
to manage these keys. ;)

Fredrik


Attachments:
hcid-hcitool.2004-02-02.patch (3.62 kB)