Hi Henryk,
I started with some cleaning up of the SBC code to better fit into
current coding conventions. My focus was on the sbc_synthesize_audio()
and sbc_analyze_audio() functions. While checking them and looking at
the code I think we also need this patch:
--- sbc/sbc.c 27 Nov 2004 21:39:38 -0000 1.23
+++ sbc/sbc.c 27 Nov 2004 21:46:01 -0000
@@ -523,7 +523,7 @@
int i, j, k;
/* Input 8 New Subband Samples */
- for (i = 0; i < 7; i++)
+ for (i = 0; i < 8; i++)
state->S[ch][i] = frame->sb_sample[blk][ch][i];
/* Shifting */
Am I right, or do I miss something?
Regards
Marcel
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Moin,
Am Sun, 28 Nov 2004 06:47:27 +0100 schrieb Marcel Holtmann:
> I hope that we get no performance problems with this cleanups.
I planned to test that anyways.
> The decoder is working for me. I tried it before I checked in my
> changes.
Hmm, you're right. I checked out the old version that I knew was working
and as that didn't work either (while sbctest _did_ work) I concluded
that simply the sound output was broken.
Hmm, somehow it stops working after some time (that is: I only get noise
on the speakers) and if I simply play any file in xmms (a second or so
will suffice) it works again ... for a couple of seconds.
--
Henryk Pl?tz
Gr??e aus Berlin
~~~~~~~ Un-CDs, nein danke! http://www.heise.de/ct/cd-register/ ~~~~~~~
~ Help Microsoft fight software piracy: Give Linux to a friend today! ~
Hi Henryk,
> > I started with some cleaning up of the SBC code to better fit into
> > current coding conventions. My focus was on the sbc_synthesize_audio()
> > and sbc_analyze_audio() functions.
>
> I saw that and you're doing a good job there.
I hope that we get no performance problems with this cleanups. This all
now depends on how good the compiler optimizes and predict stuff. I
think that we need some regression tests.
> I also saw that you
> registered sf.net/projects/sbc.
Yes, it is true. I registered the SBC library as a standalone project at
Sourceforge. Right now this is still in the setup phase, but I hope that
we can move the code over very soon. Actually this was the reason why I
tried to cleanup some things.
> > - for (i = 0; i < 7; i++)
> > + for (i = 0; i < 8; i++)
>
> > Am I right, or do I miss something?
>
> No, you're absolutely right. Actually the decoder is broken currently
> (I swear it worked when I checked in rev 1.8 of sbclib.c). I'm
> investigating...
The decoder is working for me. I tried it before I checked in my
changes.
Regards
Marcel
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Moin,
Am Sat, 27 Nov 2004 22:49:25 +0100 schrieb Marcel Holtmann:
> I started with some cleaning up of the SBC code to better fit into
> current coding conventions. My focus was on the sbc_synthesize_audio()
> and sbc_analyze_audio() functions.
I saw that and you're doing a good job there. I also saw that you
registered sf.net/projects/sbc.
> - for (i = 0; i < 7; i++)
> + for (i = 0; i < 8; i++)
> Am I right, or do I miss something?
No, you're absolutely right. Actually the decoder is broken currently
(I swear it worked when I checked in rev 1.8 of sbclib.c). I'm
investigating...
--
Henryk Pl?tz
Gr??e aus Berlin
~~~~~~~ Un-CDs, nein danke! http://www.heise.de/ct/cd-register/ ~~~~~~~
~ Help Microsoft fight software piracy: Give Linux to a friend today! ~