Hi Marcel,
In the last email about bluetoothd, you suggested send patches to enhance
hcid. I studied the hcid code and I would like align our ideas before start
coding. My suggestions are:
1. Develop a common code addressing all D-Bus versions
2. Send signals to connection complete and disconnection
3. Register a D-Bus hci object path as a initial point for bluetoothd and
provide basic services(inquiry, auth, ...).
Do you agree? Do you have suggestions/comments?
I am sending a patch to solve the problem of D-Bus versions. Sorry, byte
array is not being handled yet, but I will fix it. This is just a idea of
how solve the problem of several D-Bus versions. Get the dbus major/minor
version in the "configure" is a better approach, instead of check if the
function dbus_message_iter_get_basic belongs to the dbus-1 library. If you
allow change the makefiles(acinclude.m4, configure.in <http://configure.in>,
config.h.in <http://config.h.in> ) I can modify it.
Regards,
Claudio.
Hi Claudio,
> sorry. It's done!
patch is in, but next time also use tabs for the second line of this:
hci_send_cmd(req->dev, OGF_LINK_CTL,
OCF_PIN_CODE_NEG_REPLY, 6, &req->bda);
No spaces for indentation at all.
Regards
Marcel
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server.
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
sorry. It's done!
Regards,
Claudio.
On 9/14/05, Marcel Holtmann <[email protected]> wrote:
>
> Hi Claudio,
>
> > It's done! The changes was based on the dbus.c revision 1.15.
>
> you used spaces instead of tabs. Please redo it again.
>
> Regards
>
> Marcel
>
>
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by:
> Tame your development challenges with Apache's Geronimo App Server.
> Download it for free - -and be entered to win a 42" plasma tv or your very
> own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
> _______________________________________________
> Bluez-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
>
Hi Claudio,
> It's done! The changes was based on the dbus.c revision 1.15.
you used spaces instead of tabs. Please redo it again.
Regards
Marcel
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server.
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Marcel,
It's done! The changes was based on the dbus.c revision 1.15.
Regards,
Claudio.
On 9/13/05, Marcel Holtmann <[email protected]> wrote:
>
> Hi Claudio,
>
> > The patch for reply_handler_function is attached.
>
> please redo it against the latest CVS, because I already dropped the
> D-Bus 0.23 support.
>
> Regards
>
> Marcel
>
>
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by:
> Tame your development challenges with Apache's Geronimo App Server.
> Download it for free - -and be entered to win a 42" plasma tv or your very
> own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
> _______________________________________________
> Bluez-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
>
Hi Claudio,
> The patch for reply_handler_function is attached.
please redo it against the latest CVS, because I already dropped the
D-Bus 0.23 support.
Regards
Marcel
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server.
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Marcel,
The patch for reply_handler_function is attached.
Regards,
Claudio.
On 9/12/05, Marcel Holtmann <[email protected]> wrote:
>
> Hi Claudio,
>
> > Regarding the reply_handler_function, please check if it is relevant.
> > I you want I can send only the changes for handle the error messages.
>
> please do so.
>
> Regards
>
> Marcel
>
>
>
>
> -------------------------------------------------------
> SF.Net email is Sponsored by the Better Software Conference & EXPO
> September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> Practices
> Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
> _______________________________________________
> Bluez-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
>
Hi Claudio,
> Regarding the reply_handler_function, please check if it is relevant.
> I you want I can send only the changes for handle the error messages.
please do so.
Regards
Marcel
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Marcel,
Regarding the reply_handler_function, please check if it is relevant.
I you want I can send only the changes for handle the error messages.
Regards,
Claudio.
On 9/12/05, Marcel Holtmann <[email protected]> wrote:
>
> Hi Claudio,
>
> > I am sending a new patch that contains the following enhancements:
> > 1. Support multiple D-Bus versions(0.23, 0.30...)
> > 2. Fixed error handling ServiceDoesNotExist, NoReply,
> > UnknownService, ...
> > This condition is causing sig fault due the wrong pin value.
> > Scenario: D-Bus pin helper enabled
> > and an error different than wrong argument triggered.
>
> since bluez-utils-2.21 is out, I am going do remove the support for the
> old D-Bus 0.23 API now. So there is no need for any compat code.
>
> Regards
>
> Marcel
>
>
>
>
> -------------------------------------------------------
> SF.Net email is Sponsored by the Better Software Conference & EXPO
> September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> Practices
> Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
> _______________________________________________
> Bluez-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
>
Hi Claudio,
> I am sending a new patch that contains the following enhancements:
> 1. Support multiple D-Bus versions(0.23, 0.30...)
> 2. Fixed error handling ServiceDoesNotExist, NoReply,
> UnknownService, ...
> This condition is causing sig fault due the wrong pin value.
> Scenario: D-Bus pin helper enabled
> and an error different than wrong argument triggered.
since bluez-utils-2.21 is out, I am going do remove the support for the
old D-Bus 0.23 API now. So there is no need for any compat code.
Regards
Marcel
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Sorry,
segmentation fault :)
This problem happens because the pin will contains the long error message
string instead of a short pin number.
On 9/12/05, Claudio Takahasi <[email protected]> wrote:
>
> Hi Marcel,
>
> I am sending a new patch that contains the following enhancements:
> 1. Support multiple D-Bus versions(0.23, 0.30...)
> 2. Fixed error handling ServiceDoesNotExist, NoReply, UnknownService, ...
> This condition is causing sig fault due the wrong pin value. Scenario:
> D-Bus pin helper enabled
> and an error different than wrong argument triggered.
>
>
> Regards,
> Claudio.
>
> On 9/9/05, Marcel Holtmann <[email protected]> wrote:
> >
> > Hi Sjoerd,
> >
> > > > having 0.33 is better than 0.23 and this is what Debian unstable
> > still
> > > > uses. However lets make a list of the distributions:
> > > >
> > > > SuSE Linux 10.0 D-Bus 0.35
> > > > Fedora Core 4 D-Bus 0.33
> > > > Ubuntu Breezy D-Bus 0.36
> > > > Debian unstable D-Bus 0.23
> > > Debian experimental D-Bus 0.50
> >
> > this is good.
> >
> > > > The only bad guy is Debian unstable and I don't care anymore. They
> > use
> > > > Xorg finally and have GCC 4.0 etc., but they can't move over to the
> > next
> > > > D-Bus generation. I think that is their problem now and the release
> > of
> > > > bluez-utils-0.22 will definitely drop the support for the old D-Bus
> > 0.23
> > > > version.
> > >
> > > D-bus >= 0.3x has been in debian experimental for quite some time.
> > There are
> > > various transitions going on in debian unstable currently which makes
> > it
> > > inappropriate to do a dbus transition now too.
> >
> > Last time I looked at it, the complete KDE part was broken and full of
> > wrong dependencies. So breaking D-Bus wouldn't even be notified ;)
> >
> > > > I like to base everything around the current D-Bus 0.50 release,
> > because
> > > > the C API should be quite stable now. I will accept small
> > workarounds to
> > > > make D-Bus 0.3x work, but as soon as the distributions update their
> > > > D-Bus libraries I will drop them.
> > > >
> > > > This is not a nice thing to do, I know, but a wrong usage of D-Bus
> > lets
> > > > hcid segfault and this is not what I want.
> > >
> > > As one of debian's dbus maintainers i would advise to indeed base
> > everything on
> > > dbus >= 0.50. Hopefully it won't take too long before we can move the
> > new dbus
> > > from experimental to unstable, so the workarounds for old dbus release
> > are just
> > > not worth it.
> >
> > This means I will release bluez-utils-2.21 on the weekend, because of
> > some memory leak fixes and then I will drop D-Bus 0.23 support. So if
> > any patches need to go in before, please send them now.
> >
> > Regards
> >
> > Marcel
> >
> >
> >
> >
> > -------------------------------------------------------
> > SF.Net email is Sponsored by the Better Software Conference & EXPO
> > September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> > Practices
> > Agile & Plan-Driven Development * Managing Projects & Teams * Testing &
> > QA
> > Security * Process Improvement & Measurement *
> > http://www.sqe.com/bsce5sf
> > _______________________________________________
> > Bluez-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/bluez-devel
> >
>
>
>
Hi Marcel,
I am sending a new patch that contains the following enhancements:
1. Support multiple D-Bus versions(0.23, 0.30...)
2. Fixed error handling ServiceDoesNotExist, NoReply, UnknownService, ...
This condition is causing sig fault due the wrong pin value. Scenario: D-Bus
pin helper enabled
and an error different than wrong argument triggered.
Regards,
Claudio.
On 9/9/05, Marcel Holtmann <[email protected]> wrote:
>
> Hi Sjoerd,
>
> > > having 0.33 is better than 0.23 and this is what Debian unstable still
> > > uses. However lets make a list of the distributions:
> > >
> > > SuSE Linux 10.0 D-Bus 0.35
> > > Fedora Core 4 D-Bus 0.33
> > > Ubuntu Breezy D-Bus 0.36
> > > Debian unstable D-Bus 0.23
> > Debian experimental D-Bus 0.50
>
> this is good.
>
> > > The only bad guy is Debian unstable and I don't care anymore. They use
> > > Xorg finally and have GCC 4.0 etc., but they can't move over to the
> next
> > > D-Bus generation. I think that is their problem now and the release of
> > > bluez-utils-0.22 will definitely drop the support for the old D-Bus
> 0.23
> > > version.
> >
> > D-bus >= 0.3x has been in debian experimental for quite some time. There
> are
> > various transitions going on in debian unstable currently which makes it
> > inappropriate to do a dbus transition now too.
>
> Last time I looked at it, the complete KDE part was broken and full of
> wrong dependencies. So breaking D-Bus wouldn't even be notified ;)
>
> > > I like to base everything around the current D-Bus 0.50 release,
> because
> > > the C API should be quite stable now. I will accept small workarounds
> to
> > > make D-Bus 0.3x work, but as soon as the distributions update their
> > > D-Bus libraries I will drop them.
> > >
> > > This is not a nice thing to do, I know, but a wrong usage of D-Bus
> lets
> > > hcid segfault and this is not what I want.
> >
> > As one of debian's dbus maintainers i would advise to indeed base
> everything on
> > dbus >= 0.50. Hopefully it won't take too long before we can move the
> new dbus
> > from experimental to unstable, so the workarounds for old dbus release
> are just
> > not worth it.
>
> This means I will release bluez-utils-2.21 on the weekend, because of
> some memory leak fixes and then I will drop D-Bus 0.23 support. So if
> any patches need to go in before, please send them now.
>
> Regards
>
> Marcel
>
>
>
>
> -------------------------------------------------------
> SF.Net email is Sponsored by the Better Software Conference & EXPO
> September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> Practices
> Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
> _______________________________________________
> Bluez-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
>
Hi Sjoerd,
> > having 0.33 is better than 0.23 and this is what Debian unstable still
> > uses. However lets make a list of the distributions:
> >
> > SuSE Linux 10.0 D-Bus 0.35
> > Fedora Core 4 D-Bus 0.33
> > Ubuntu Breezy D-Bus 0.36
> > Debian unstable D-Bus 0.23
> Debian experimental D-Bus 0.50
this is good.
> > The only bad guy is Debian unstable and I don't care anymore. They use
> > Xorg finally and have GCC 4.0 etc., but they can't move over to the next
> > D-Bus generation. I think that is their problem now and the release of
> > bluez-utils-0.22 will definitely drop the support for the old D-Bus 0.23
> > version.
>
> D-bus >= 0.3x has been in debian experimental for quite some time. There are
> various transitions going on in debian unstable currently which makes it
> inappropriate to do a dbus transition now too.
Last time I looked at it, the complete KDE part was broken and full of
wrong dependencies. So breaking D-Bus wouldn't even be notified ;)
> > I like to base everything around the current D-Bus 0.50 release, because
> > the C API should be quite stable now. I will accept small workarounds to
> > make D-Bus 0.3x work, but as soon as the distributions update their
> > D-Bus libraries I will drop them.
> >
> > This is not a nice thing to do, I know, but a wrong usage of D-Bus lets
> > hcid segfault and this is not what I want.
>
> As one of debian's dbus maintainers i would advise to indeed base everything on
> dbus >= 0.50. Hopefully it won't take too long before we can move the new dbus
> from experimental to unstable, so the workarounds for old dbus release are just
> not worth it.
This means I will release bluez-utils-2.21 on the weekend, because of
some memory leak fixes and then I will drop D-Bus 0.23 support. So if
any patches need to go in before, please send them now.
Regards
Marcel
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
On Fri, Sep 09, 2005 at 11:37:25AM +0200, Marcel Holtmann wrote:
> Hi Pete,
>
> > I think 0.5 is compatible with >0.35. The current FC4 only uses 0.33
> > and I don't think its compatible with > 0.35. I think this is similar
> > for a number of the current releases (I think most with gnome 2.10)
> > but obviously isn't the case for the development streams that aren't
> > releases yet.
>
> having 0.33 is better than 0.23 and this is what Debian unstable still
> uses. However lets make a list of the distributions:
>
> SuSE Linux 10.0 D-Bus 0.35
> Fedora Core 4 D-Bus 0.33
> Ubuntu Breezy D-Bus 0.36
> Debian unstable D-Bus 0.23
Debian experimental D-Bus 0.50
>
> The only bad guy is Debian unstable and I don't care anymore. They use
> Xorg finally and have GCC 4.0 etc., but they can't move over to the next
> D-Bus generation. I think that is their problem now and the release of
> bluez-utils-0.22 will definitely drop the support for the old D-Bus 0.23
> version.
D-bus >= 0.3x has been in debian experimental for quite some time. There are
various transitions going on in debian unstable currently which makes it
inappropriate to do a dbus transition now too.
> I like to base everything around the current D-Bus 0.50 release, because
> the C API should be quite stable now. I will accept small workarounds to
> make D-Bus 0.3x work, but as soon as the distributions update their
> D-Bus libraries I will drop them.
>
> This is not a nice thing to do, I know, but a wrong usage of D-Bus lets
> hcid segfault and this is not what I want.
As one of debian's dbus maintainers i would advise to indeed base everything on
dbus >= 0.50. Hopefully it won't take too long before we can move the new dbus
from experimental to unstable, so the workarounds for old dbus release are just
not worth it.
Sjoerd
--
He keeps differentiating, flying off on a tangent.
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Pete,
> I think 0.5 is compatible with >0.35. The current FC4 only uses 0.33
> and I don't think its compatible with > 0.35. I think this is similar
> for a number of the current releases (I think most with gnome 2.10)
> but obviously isn't the case for the development streams that aren't
> releases yet.
having 0.33 is better than 0.23 and this is what Debian unstable still
uses. However lets make a list of the distributions:
SuSE Linux 10.0 D-Bus 0.35
Fedora Core 4 D-Bus 0.33
Ubuntu Breezy D-Bus 0.36
Debian unstable D-Bus 0.23
The only bad guy is Debian unstable and I don't care anymore. They use
Xorg finally and have GCC 4.0 etc., but they can't move over to the next
D-Bus generation. I think that is their problem now and the release of
bluez-utils-0.22 will definitely drop the support for the old D-Bus 0.23
version.
I like to base everything around the current D-Bus 0.50 release, because
the C API should be quite stable now. I will accept small workarounds to
make D-Bus 0.3x work, but as soon as the distributions update their
D-Bus libraries I will drop them.
This is not a nice thing to do, I know, but a wrong usage of D-Bus lets
hcid segfault and this is not what I want.
Regards
Marcel
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
>
> > 1. Develop a common code addressing all D-Bus versions
>
> not needed, because my plan is to drop support for anything below D-Bus
> version 0.5 (which should be compatible with D-Bus 0.3x) starting with
> bluez-utils-0.22. My original plan was to do it in next release, but
> there are some memory leak fixes and I want to get out a new version as
> soon as possible. However maybe it is a good idea to drop support for
> older D-Bus versions now.
I think 0.5 is compatible with >0.35. The current FC4 only uses 0.33 and I
don't think its compatible with >0.35. I think this is similar for a number
of the current releases (I think most with gnome 2.10) but obviously isn't
the case for the development streams that aren't releases yet.
Pete
Hi Claudio,
> In the last email about bluetoothd, you suggested send patches to
> enhance hcid. I studied the hcid code and I would like align our ideas
> before start coding. My suggestions are:
>
> 1. Develop a common code addressing all D-Bus versions
not needed, because my plan is to drop support for anything below D-Bus
version 0.5 (which should be compatible with D-Bus 0.3x) starting with
bluez-utils-0.22. My original plan was to do it in next release, but
there are some memory leak fixes and I want to get out a new version as
soon as possible. However maybe it is a good idea to drop support for
older D-Bus versions now.
It seems the only problematic distribution is Debian unstable. Every
other distribution (including Ubuntu) uses at least D-Bus 0.35.
> 2. Send signals to connection complete and disconnection
While I was adding the signals for the inquiry responses, I thought
about doing this, too. I added the needed functions for it and open the
filter for these messages. The only problem is that the disconnect uses
the ACL handle and not the device address. This means you have to keep
track of all handles. Normally the kernel does this all for us. This is
one reason for a good/new interface between the kernel and bluetoothd.
Coding everything twice is stupid.
> 3. Register a D-Bus hci object path as a initial point for bluetoothd
> and provide basic services(inquiry, auth, ...).
Go ahead. I would really welcome it.
I need a job where I can fulltime work on bluetoothd and add all the
cool things we talked about. If anyone know one or has one, let me know.
> I am sending a patch to solve the problem of D-Bus versions. Sorry,
> byte array is not being handled yet, but I will fix it. This is just a
> idea of how solve the problem of several D-Bus versions. Get the dbus
> major/minor version in the "configure" is a better approach, instead
> of check if the function dbus_message_iter_get_basic belongs to the
> dbus-1 library. If you allow change the makefiles(acinclude.m4,
> configure.in, config.h.in ) I can modify it.
I like to drop support for older D-Bus versions. After a private talk
with J5 it seems the only sane way to do.
Regards
Marcel
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel