2006-11-07 15:16:21

by Jose Vasconcellos

[permalink] [raw]
Subject: [Bluez-devel] Bonding

Hello,

I see that the dbus message RemoveBonding clears the link key
on the bluetooth adapter but does not remove the entry from the
linkkeys file. Afterwards ListBondings still shows a bonding and
CreateBonding reports that a bonding already exists. Is this the
correct behavior?

Jose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel


2006-11-07 21:37:40

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] Case handling (was: Bonding)

Hi Jose,

> Looking at this code I find the logic a bit convoluted.
> I don't see the point of the case checking. Wouldn't
> be easier to convert any address coming from the dbus
> to upper case once?

I added now textfile_casedel() and it makes use of it. So the CVS
version should work as expected.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-11-07 20:28:18

by Jose Vasconcellos

[permalink] [raw]
Subject: [Bluez-devel] Case handling (was: Bonding)

Hi Marcel,

Looking at this code I find the logic a bit convoluted.
I don't see the point of the case checking. Wouldn't
be easier to convert any address coming from the dbus
to upper case once?

Jose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-11-07 20:22:31

by Jose Vasconcellos

[permalink] [raw]
Subject: Re: [Bluez-devel] Bonding

Marcel Holtmann wrote:
> Hi Jose,
>
>
>>>>>>>> I see that the dbus message RemoveBonding clears the link key
>>>>>>>> on the bluetooth adapter but does not remove the entry from the
>>>>>>>> linkkeys file. Afterwards ListBondings still shows a bonding and
>>>>>>>> CreateBonding reports that a bonding already exists. Is this the
>>>>>>>> correct behavior?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> actually it should remove the entry from the linkkeys file. Otherwise
>>>>>>> this is a bug. Can you check the log files for errors.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> I don't see any error message in syslog or anywhere else.
>>>>>> The commands themselves don't seem to report anything
>>>>>> unusual.
>>>>>>
>>>>>>
>>>>>>
>>>>> I am pretty sure that it works as expected. What distro do you have
>>>>> running. Maybe SELinux is restricting access to /var/lib/bluetooth/
>>>>>
>>>>>
>>>> OK, I did a little bit of digging and here's a better description:
>>>> Removing a device that has lower case hex numbers does not
>>>> remove it from the linkkeys file. You must use upper case.
>>>>
>>>>
>>> that should have been fixed. What version of bluez-utils are you
>>> running.
>>>
>>>
>> I'm running the latest, version 3.7 on Ubuntu 6.06.
>>
>
> check the CVS when it was fixed (if we didn't forget it). I am pretty
> sure that if was fixed before 3.7, but I might be mistaken here. If it
> is still broken or the patch was incomplete, please fix it and send in a
> patch for it.
>
> Regards
>
> Marcel
>
Looks like the problem is that the function textfile_del in
common/textfile.c
calls write_key with the icase parameter set to 0. This is NOT fixed in CVS.

Jose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-11-07 20:57:09

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] Bonding

Hi Jose,

> >>>>>> I see that the dbus message RemoveBonding clears the link key
> >>>>>> on the bluetooth adapter but does not remove the entry from the
> >>>>>> linkkeys file. Afterwards ListBondings still shows a bonding and
> >>>>>> CreateBonding reports that a bonding already exists. Is this the
> >>>>>> correct behavior?
> >>>>>>
> >>>>>>
> >>>>> actually it should remove the entry from the linkkeys file. Otherwise
> >>>>> this is a bug. Can you check the log files for errors.
> >>>>>
> >>>>>
> >>>> I don't see any error message in syslog or anywhere else.
> >>>> The commands themselves don't seem to report anything
> >>>> unusual.
> >>>>
> >>>>
> >>> I am pretty sure that it works as expected. What distro do you have
> >>> running. Maybe SELinux is restricting access to /var/lib/bluetooth/
> >>>
> >> OK, I did a little bit of digging and here's a better description:
> >> Removing a device that has lower case hex numbers does not
> >> remove it from the linkkeys file. You must use upper case.
> >>
> >
> > that should have been fixed. What version of bluez-utils are you
> > running.
> >
> I'm running the latest, version 3.7 on Ubuntu 6.06.

check the CVS when it was fixed (if we didn't forget it). I am pretty
sure that if was fixed before 3.7, but I might be mistaken here. If it
is still broken or the patch was incomplete, please fix it and send in a
patch for it.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-11-07 19:50:15

by Jose Vasconcellos

[permalink] [raw]
Subject: Re: [Bluez-devel] Bonding

Marcel Holtmann wrote:
> Hi Jose,
>
>
>>>>>> I see that the dbus message RemoveBonding clears the link key
>>>>>> on the bluetooth adapter but does not remove the entry from the
>>>>>> linkkeys file. Afterwards ListBondings still shows a bonding and
>>>>>> CreateBonding reports that a bonding already exists. Is this the
>>>>>> correct behavior?
>>>>>>
>>>>>>
>>>>> actually it should remove the entry from the linkkeys file. Otherwise
>>>>> this is a bug. Can you check the log files for errors.
>>>>>
>>>>>
>>>> I don't see any error message in syslog or anywhere else.
>>>> The commands themselves don't seem to report anything
>>>> unusual.
>>>>
>>>>
>>> I am pretty sure that it works as expected. What distro do you have
>>> running. Maybe SELinux is restricting access to /var/lib/bluetooth/
>>>
>> OK, I did a little bit of digging and here's a better description:
>> Removing a device that has lower case hex numbers does not
>> remove it from the linkkeys file. You must use upper case.
>>
>
> that should have been fixed. What version of bluez-utils are you
> running.
>
> Regards
>
> Marcel
>
>
I'm running the latest, version 3.7 on Ubuntu 6.06.

Jose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-11-07 20:41:12

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] Bonding

Hi Jose,

> >>>> I see that the dbus message RemoveBonding clears the link key
> >>>> on the bluetooth adapter but does not remove the entry from the
> >>>> linkkeys file. Afterwards ListBondings still shows a bonding and
> >>>> CreateBonding reports that a bonding already exists. Is this the
> >>>> correct behavior?
> >>>>
> >>> actually it should remove the entry from the linkkeys file. Otherwise
> >>> this is a bug. Can you check the log files for errors.
> >>>
> >> I don't see any error message in syslog or anywhere else.
> >> The commands themselves don't seem to report anything
> >> unusual.
> >>
> >
> > I am pretty sure that it works as expected. What distro do you have
> > running. Maybe SELinux is restricting access to /var/lib/bluetooth/
>
> OK, I did a little bit of digging and here's a better description:
> Removing a device that has lower case hex numbers does not
> remove it from the linkkeys file. You must use upper case.

that should have been fixed. What version of bluez-utils are you
running.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-11-07 19:36:25

by Jose Vasconcellos

[permalink] [raw]
Subject: Re: [Bluez-devel] Bonding

Marcel Holtmann wrote:
> Hi Jose,
>
>
>>>> I see that the dbus message RemoveBonding clears the link key
>>>> on the bluetooth adapter but does not remove the entry from the
>>>> linkkeys file. Afterwards ListBondings still shows a bonding and
>>>> CreateBonding reports that a bonding already exists. Is this the
>>>> correct behavior?
>>>>
>>> actually it should remove the entry from the linkkeys file. Otherwise
>>> this is a bug. Can you check the log files for errors.
>>>
>> I don't see any error message in syslog or anywhere else.
>> The commands themselves don't seem to report anything
>> unusual.
>>
>
> I am pretty sure that it works as expected. What distro do you have
> running. Maybe SELinux is restricting access to /var/lib/bluetooth/
>
> Regards
>
> Marcel
>

OK, I did a little bit of digging and here's a better description:
Removing a device that has lower case hex numbers does not
remove it from the linkkeys file. You must use upper case.

Jose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-11-07 18:25:08

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] Bonding

Hi Jose,

> >> I see that the dbus message RemoveBonding clears the link key
> >> on the bluetooth adapter but does not remove the entry from the
> >> linkkeys file. Afterwards ListBondings still shows a bonding and
> >> CreateBonding reports that a bonding already exists. Is this the
> >> correct behavior?
> >
> > actually it should remove the entry from the linkkeys file. Otherwise
> > this is a bug. Can you check the log files for errors.
>
> I don't see any error message in syslog or anywhere else.
> The commands themselves don't seem to report anything
> unusual.

I am pretty sure that it works as expected. What distro do you have
running. Maybe SELinux is restricting access to /var/lib/bluetooth/

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-11-07 17:16:07

by Jose Vasconcellos

[permalink] [raw]
Subject: Re: [Bluez-devel] Bonding

Marcel Holtmann wrote:
> Hi Jose,
>
>
>> I see that the dbus message RemoveBonding clears the link key
>> on the bluetooth adapter but does not remove the entry from the
>> linkkeys file. Afterwards ListBondings still shows a bonding and
>> CreateBonding reports that a bonding already exists. Is this the
>> correct behavior?
>>
>
> actually it should remove the entry from the linkkeys file. Otherwise
> this is a bug. Can you check the log files for errors.
>
> Regards
>
> Marcel
>

Hi Marcel,

I don't see any error message in syslog or anywhere else.
The commands themselves don't seem to report anything
unusual.

Jose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-11-07 15:26:54

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] Bonding

Hi Jose,

> I see that the dbus message RemoveBonding clears the link key
> on the bluetooth adapter but does not remove the entry from the
> linkkeys file. Afterwards ListBondings still shows a bonding and
> CreateBonding reports that a bonding already exists. Is this the
> correct behavior?

actually it should remove the entry from the linkkeys file. Otherwise
this is a bug. Can you check the log files for errors.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel