2007-10-27 13:06:20

by Fabien Chevalier

[permalink] [raw]
Subject: [PATCH] common/ dbus cleanup


Marcel, while looking to move error stuff to common/, i came across
some bits of duplicated code.

Basically send_message_and_unref (dbus.h) and dbus_connection_send_and_unref
(dbus-helper.h) are the same functions, and
are both used in the code :-)

The attached patch simply removes send_message_and_unref and moves all its users
to dbus_connection_send_and_unref.

Regards,

Fabien


2007-10-27 15:43:20

by Fabien Chevalier

[permalink] [raw]
Subject: [PATCH] common/ dbus cleanup : with patch this time :-)

Yet again i forgot to attach the patch :-( ghhrrrmmm

>
> Marcel, while looking to move error stuff to common/, i came across
> some bits of duplicated code.
>
> Basically send_message_and_unref (dbus.h) and dbus_connection_send_and_unref
> (dbus-helper.h) are the same functions, and
> are both used in the code :-)
>
> The attached patch simply removes send_message_and_unref and moves all its
> users
> to dbus_connection_send_and_unref.
>
> Regards,
>
> Fabien



Attachments:
dbus-helper-usage-cleanup.diff (85.96 kB)