_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Fabien,
> > > Btw did you have a look at the send_message_and_unref ==>
> > > dbus_connection_send_and_unref patch ? Is it ok for you ? (Aven't tested
> > but i
> > > think those three patches may depend on it)
> >
> > Not really. I leave this to Johan, since he worked on most of common/
> > stuff.
>
> Ok, wrong door :-)
> I'll put this one on the list of the patches that johan has to review then ;-)
>
> Should i go through Johan for the exceptions cleanup patches too ?
sure. Make him review and commit you patches.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Marcel,
> > Btw did you have a look at the send_message_and_unref ==>
> > dbus_connection_send_and_unref patch ? Is it ok for you ? (Aven't tested
> but i
> > think those three patches may depend on it)
>
> Not really. I leave this to Johan, since he worked on most of common/
> stuff.
Ok, wrong door :-)
I'll put this one on the list of the patches that johan has to review then ;-)
Should i go through Johan for the exceptions cleanup patches too ?
Regards,
Fabien
Hi Fabien,
> > I like to have org.bluez.Error only. There is no need to get an extra
> > hierarchy level.
> >
>
> That's basically how things are today... however if have no objection if you
> want to change that...
it is this way, because it was the easiest way. I want one
org.bluez.Error to handle all error cases.
> Btw did you have a look at the send_message_and_unref ==>
> dbus_connection_send_and_unref patch ? Is it ok for you ? (Aven't tested but i
> think those three patches may depend on it)
Not really. I leave this to Johan, since he worked on most of common/
stuff.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Marcel
> I like to have org.bluez.Error only. There is no need to get an extra
> hierarchy level.
>
That's basically how things are today... however if have no objection if you
want to change that...
Btw did you have a look at the send_message_and_unref ==>
dbus_connection_send_and_unref patch ? Is it ok for you ? (Aven't tested but i
think those three patches may depend on it)
Please find attached an updated patchset moving everything to org.bluez.Error...
as usual, any more comments are welcomed :-)
Cheers,
Fabien
Hi Marcel
> I like to have org.bluez.Error only. There is no need to get an extra
> hierarchy level.
>
That's basically how things are today... however if have no objection if you
want to change that...
Btw did you have a look at the send_message_and_unref ==>
dbus_connection_send_and_unref patch ? Is it ok for you ? (Aven't tested but i
think those three patches may depend on it)
Please find attached an updated patchset moving everything to org.bluez.Error...
as usual, any more comments are welcomed :-)
Cheers,
Fabien
Hi Fabien,
> This is the first patch for what i have in mind for the dbus errors management:
> - org.bluez.Error.xxx : generic errors used by hcid and all services, declared
> in common-error.h
> - org.bluez.Error.SERVICENAME.yyy : errors that have a meaning only to a local
> service.
> - org.bluez.core.Error.zzz : errors that have a meaning local to hcid, not
> shared with other services.
I like to have org.bluez.Error only. There is no need to get an extra
hierarchy level.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel