_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Vinicius,
> > > It only exports a local (127.0.0.1) port, but could be easily modified
> > > to export a port from any host. It is really simple as all the hard
> > > work was already done for the Unix socket proxy. My primary interest
> > > is export the internal N810 GPS so other devices can use it.
> >
> > patch looks good, but it contains to many unneeded hunks. Which
> > indicates that you only changed whitespace into tabs or vise versa.
> > Please use an editor that visually shows whitespaces and tabs.
>
> Many of these hunks were showing whitespace being removed from the end
> of some lines. Also there was a line with just a tab on it.
and your new patch introduced as many as it fixes. I am serious about
this and once you look at the diff file, I can even tell without
whitespace visualization. I fixed it up for you, but make sure in the
future this is all sane and sound. Patch is in the CVS.
Regards
Marcel
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Vinicius,
> It only exports a local (127.0.0.1) port, but could be easily modified
> to export a port from any host. It is really simple as all the hard
> work was already done for the Unix socket proxy. My primary interest
> is export the internal N810 GPS so other devices can use it.
patch looks good, but it contains to many unneeded hunks. Which
indicates that you only changed whitespace into tabs or vise versa.
Please use an editor that visually shows whitespaces and tabs.
First thing it is "unsigned short port" and not some "short int" or
something. This also means you can skip all reformatting in struct
proxy.
Don't introduce extra empty lines in your if or case statements. They
are not needed.
Regards
Marcel
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel