2008-04-04 18:54:42

by Mario Limonciello

[permalink] [raw]
Subject: [Bluez-devel] [PATCH] Add HID->HCI switching support for newer Dell BT cards

Hello,

As I've recently discovered, the more recent (Dell Wireless 370+) BT
adapters with the latest firmware don't come up in Bluetooth Radio mode.
They come up in a HID/UHE dongle like mode before the OS loads and
expect the OS to transition the device to HCI mode. Unfortunately, the
transition to HCI mode isn't done in the same fashion as the existing
switch_hidproxy function available in hid2hci. I'm attaching a patch to
hid2hci that adds a function for the expected behavior on these newer
adapters.

The device that needs to have the report sent to it is claimed by usbhid
at OS load time, so there are some calls in there to release it from
usbhid.

I tested this against a Dell 370 BT adapter. This should be the same
for the newer adapters (after the 370), but I haven't verified them yet,
so there may be an additional patch needed for it.

Thanks,

---
Mario Limonciello
Dell | Linux Engineering
[email protected]



Attachments:
007_dell_bluetooth.patch (1.44 kB)
signature.asc (189.00 B)
This is a digitally signed message part
(No filename) (278.00 B)
(No filename) (164.00 B)
Download all attachments

2008-04-04 23:17:05

by Bastien Nocera

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Add HID->HCI switching support for newer Dell BT cards


On Fri, 2008-04-04 at 15:46 -0500, [email protected] wrote:
> Hi,
>
> As it turns out, this also works for the Dell 410 series cards.
> Attached is an updated patch to include them.

Only problems I could see with the patch is the coding style (C++-style
comments, braces on different lines for a condition, alignment of
arguments to a function when on multiple lines).

The rest of the code looks fine to me.

Are those adapters usually shipped with keyboards and mice, so that they
would need to stay in HID mode on startup?

If they do, do you have any code available that would make sure this
keyboard and mouse are registered in BlueZ so they work "out of the
box"?


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2008-04-04 20:46:38

by Mario Limonciello

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Add HID->HCI switching support for newer Dell BT cards

Hi,

As it turns out, this also works for the Dell 410 series cards.
Attached is an updated patch to include them.

Regards,

On Fri, 2008-04-04 at 13:54 -0500, Mario Limonciello wrote:

> Hello,
>
> As I've recently discovered, the more recent (Dell Wireless 370+) BT
> adapters with the latest firmware don't come up in Bluetooth Radio
> mode. They come up in a HID/UHE dongle like mode before the OS loads
> and expect the OS to transition the device to HCI mode.
> Unfortunately, the transition to HCI mode isn't done in the same
> fashion as the existing switch_hidproxy function available in hid2hci.
> I'm attaching a patch to hid2hci that adds a function for the expected
> behavior on these newer adapters.
>
> The device that needs to have the report sent to it is claimed by
> usbhid at OS load time, so there are some calls in there to release it
> from usbhid.
>
> I tested this against a Dell 370 BT adapter. This should be the same
> for the newer adapters (after the 370), but I haven't verified them
> yet, so there may be an additional patch needed for it.
>
> Thanks,
>
> ---
> Mario Limonciello
> Dell | Linux Engineering
> [email protected]
>
>
>

---
Mario Limonciello
Dell | Linux Engineering
Desk : (512) 723-0582
[email protected]



Attachments:
007_dell_bluetooth.patch (1.50 kB)
signature.asc (189.00 B)
This is a digitally signed message part
(No filename) (278.00 B)
(No filename) (164.00 B)
Download all attachments