_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Frederic,
> I got my hand over a BNEP and PAN test plan and tried to pass it with
> current PAN implementation (pand, not network service). I met several
> issues and tried to find some solutions to them.
>
> * Handling of 32 and 128 bits uuids,
> * Correct response to invalid uuids,
> * Respond to control messages before connection setup,
> * Handling of bnep extension together with general headers,
> * Handling of bnep extensions together with setup connection requests.
> * Forwarding of unknown BNEP extensions (not available for broadcast,
> advice requested),
> * Give up pan connection after 30 seconds,
>
> The result of that work is two patchs, one for the kernel (based on
> latest git) and one for pand (a bit old that one I fear). However, it
> should be easy to get similar patch for network service.
I need both patches in unified diff format (-u). I am not a machine and
can't read context diffs.
Please break up the kernel patch in small chunks that solve each
problem. It is easier for me to review them and then apply them.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
On Thu, Apr 17, 2008 at 3:26 PM, Marcel Holtmann <[email protected]> wrote:
> Hi Luiz,
>
>
> > pand is deprecated so it should be good if you can take a look in
> > network plugin and see if it surfer from the same problems.
>
> both share the kernel layer. So we have to fix that part first.
>
> Regards
>
> Marcel
>
>
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
> Don't miss this year's exciting event. There's still time to save $100.
> Use priority code J8TL2D2.
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________
> Bluez-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
>
Hi,
Does it make sense validate the source and destination uuid in the kernel?
We also need to decode the setup connection request message and reply
an error when the server is not enabled. Suppose that PANU and GN are
enabled and NAP is disabled. If destination requested is NAP the
response message should be not allowed, correct?
Another point, it is necessary check source/destination role
combination. For example: GN <->GN, NAP<->NAP, GN<->NAP must be
rejected.
Regards,
Claudio.
--
--
Claudio Takahasi
Instituto Nokia de Tecnologia
Recife - Pernambuco - Brasil
+55 81 30879999
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Luiz,
> pand is deprecated so it should be good if you can take a look in
> network plugin and see if it surfer from the same problems.
both share the kernel layer. So we have to fix that part first.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Frederic,
pand is deprecated so it should be good if you can take a look in
network plugin and see if it surfer from the same problems.
-- =
Luiz Augusto von Dentz
Engenheiro de Computa=E7=E3o
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference =
Don't miss this year's exciting event. There's still time to save $100. =
Use priority code J8TL2D2. =
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/java=
one
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
>> A part of the patch si to move handling of incoming setup_conn_req
>> in kernel. In order to keep pan working with older kernel, some
>> differenciation must be done. How to achieve this ?
>>
>
> I don't know yet. Can we first fix the issues that don't need
> modifications within the kernel. I prefer not modifying the kernel at
> all at the moment.
>
>
I understand.
My problem is that some tests require grouping several messages into
one. In particular, the setup_conn_req can be sent together with a
control extension TP/BNEP/CTRL/BV-19-C.
The current extension processing is to skip everything and I'm not sure
the control message can be handled at application level.
Frederic
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Frederic,
>>> I got my hand over a BNEP and PAN test plan and tried to pass it
>>> with current PAN implementation (pand, not network service). I met
>>> several issues and tried to find some solutions to them.
>>>
>>> * Handling of 32 and 128 bits uuids,
>>> * Correct response to invalid uuids,
>>> * Respond to control messages before connection setup,
>>> * Handling of bnep extension together with general headers,
>>> * Handling of bnep extensions together with setup connection
>>> requests.
>>> * Forwarding of unknown BNEP extensions (not available for
>>> broadcast, advice requested),
>>> * Give up pan connection after 30 seconds,
>>>
>>> The result of that work is two patchs, one for the kernel (based
>>> on latest git) and one for pand (a bit old that one I fear).
>>> However, it should be easy to get similar patch for network service.
>>>
>>
>> I need both patches in unified diff format (-u). I am not a machine
>> and
>> can't read context diffs.
>>
>> Please break up the kernel patch in small chunks that solve each
>> problem. It is easier for me to review them and then apply them.
>>
>
> Sorry for long delay, i was ooto. Will split patch and send with -u.
> For now here is first patch for pand and network service.
>
> Give up pan connection after 30 seconds
> TP/BNEP/CTRL/BV-02-C
patch looks good to me.
Luiz, feel free to apply it.
> A part of the patch si to move handling of incoming setup_conn_req
> in kernel. In order to keep pan working with older kernel, some
> differenciation must be done. How to achieve this ?
I don't know yet. Can we first fix the issues that don't need
modifications within the kernel. I prefer not modifying the kernel at
all at the moment.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Frederic,
I hope the patch for bluez-utils doesn't make it block for 30s, other
than that it looks fine. But I cannot apply it to cvs since Marcel
removed the permission, so we got to wait for git repository.
-- =
Luiz Augusto von Dentz
Engenheiro de Computa=E7=E3o
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great priz=
es
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=3D100&url=3D/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Any updates?
Fr=E9d=E9ric DALLEAU
Fr=E9d=E9ric Dalleau wrote:
> Marcel, Luiz
>
>>>> A part of the patch si to move handling of incoming setup_conn_req =
>>>> in kernel. In order to keep pan working with older kernel, some =
>>>> differenciation must be done. How to achieve this ?
>>>> =
>>> I don't know yet. Can we first fix the issues that don't need =
>>> modifications within the kernel. I prefer not modifying the kernel =
>>> at all at the moment. =
>>
>> I understand.
>> My problem is that some tests require grouping several messages into =
>> one. In particular, the setup_conn_req can be sent together with a =
>> control extension TP/BNEP/CTRL/BV-19-C.
>> The current extension processing is to skip everything and I'm not =
>> sure the control message can be handled at application level.
>> =
>
> I wake up this thread,
>
> I'm working at making this easier to integrate but it will makes a =
> bunch of patches.
> Let's start with the small and self contained.
>
> Resend patch for bluez-utils, and network service timeout (after =
> SETUP_CONN_REQ is sent and no answer for 30 sec, disconnect)
>
> Other patch adds a parameter to bnep module for disabling header =
> compression.
>
> Let me know what you think.
> Regards,
>
> Fr=E9d=E9ric DALLEAU
>
>
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
> Studies have shown that voting for your favorite open source project,
> along with a healthy diet, reduces your potential for chronic lameness
> and boredom. Vote Now at http://www.sourceforge.net/community/cca08
> ------------------------------------------------------------------------
>
> _______________________________________________
> Bluez-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great priz=
es
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=3D100&url=3D/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Frederic,
> I'm working at making this easier to integrate but it will makes a bunch
> of patches.
> Let's start with the small and self contained.
>
> Resend patch for bluez-utils, and network service timeout (after
> SETUP_CONN_REQ is sent and no answer for 30 sec, disconnect)
I applied the bluez-utils patches to our 4.x repository.
> Other patch adds a parameter to bnep module for disabling header
> compression.
I am going through that one know.
Regards
Marcel
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
Hi Frederic,
> Great you could start integrating.
> Please find attached the remaining patches.
the 0001 patch contains an extra setup variable that is not used in the
patch at all. Remove it from it.
The 0002 patch mixes the non-understood changes with the setup changes.
Also can we just use flags variable in the session instead of setup. The
UUID handling could be done a little bit more elegant.
What is the point behind 0003 patch?
I think 0004 patch needs some cleanup. It looks too hackish.
The 0006 patch is not how we handle this. Either use the exported
version number of the BNEP module or we have to add an ioctl for it.
Please don't hijack a thread for this and send these patches one by one
to [email protected].
Regards
Marcel
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel