2004-02-10 11:49:42

by Collin R. Mulliner

[permalink] [raw]
Subject: [Bluez-devel] L2CAP raw socket patch

Hi List,

I have written a small patch for l2cap.c to improve the capabilities of
L2CAP raw sockets. Currently only very few responses travel back to a
RAW socket (which is very bad if you need to see command responses).
The patch is very simple - it just puts all responses on the
Sig-Channel to all open RAW sockets. The owner of the raw socket just
needs to select his packets and in normal operation there shouldn't be
much use of RAW sockets so I don't think this is a performance issue.

I have attached the patch file to this email, hope this is ok.


thanks ... Collin

--
Collin Mulliner <[email protected]>
BATAVERSiON Systems [http://www.betaversion.net]
Don't ask why! Ask why not!


Attachments:
bluez_l2cap_rawsocket.patch (864.00 B)

2004-02-10 22:16:48

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] L2CAP raw socket patch

Hi Collin,

> I have written a small patch for l2cap.c to improve the capabilities of
> L2CAP raw sockets. Currently only very few responses travel back to a
> RAW socket (which is very bad if you need to see command responses).
> The patch is very simple - it just puts all responses on the
> Sig-Channel to all open RAW sockets. The owner of the raw socket just
> needs to select his packets and in normal operation there shouldn't be
> much use of RAW sockets so I don't think this is a performance issue.

do anyone have comments about this patch?

> I have attached the patch file to this email, hope this is ok.

BTW this patch is wrong, because we must keep the case statements.
Otherwise the kernel log will be filled with unneeded error messages.

Regards

Marcel


Attachments:
patch (707.00 B)