2004-08-30 15:53:25

by Till Harbaum

[permalink] [raw]
Subject: [Bluez-devel] Small bugfix for hstest

Hi,

i have played around with hstest and some uart based hardware and found a
problem, that only seems to happen with uart based devices:

A client may receive sco data packets that are bigger than the sco mtu. hstest
returns packets of exactly the same size of the packets it received. If the
packet received is bigger then the sco mtu, then packets bigger than sco mtu
are being sent and being dropped in the kernel. As a result, no data is being
sent at all. Instead multiple smaller sco packets should be sent.

The attached patch has to be applied to bluez-utils/test/hstest.c and fixes
the problem inside hstest. It would as well be possible to make the kernel
sco code detect this and fragment the payload accordingly. But imho this
should be done in the application.

Regards,
Till

--
Dr.-Ing. Till Harbaum Tel.: +49 721 4998963
BeeCon GmbH Fax: +49 721 4998962
Haid-und-Neu Strasse 7, 76131 Karlsruhe Mobil: +49 179 9087904
[email protected] http://www.beecon.de


Attachments:
(No filename) (1.05 kB)
hstest-uart.patch (691.00 B)
Download all attachments

2004-08-30 16:07:10

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] Small bugfix for hstest

Hi Till,

> i have played around with hstest and some uart based hardware and found a
> problem, that only seems to happen with uart based devices:
>
> A client may receive sco data packets that are bigger than the sco mtu. hstest
> returns packets of exactly the same size of the packets it received. If the
> packet received is bigger then the sco mtu, then packets bigger than sco mtu
> are being sent and being dropped in the kernel. As a result, no data is being
> sent at all. Instead multiple smaller sco packets should be sent.
>
> The attached patch has to be applied to bluez-utils/test/hstest.c and fixes
> the problem inside hstest. It would as well be possible to make the kernel
> sco code detect this and fragment the payload accordingly. But imho this
> should be done in the application.

I applied the patch, but there must be space between "while" and "(" to
keep me and the coding style happy ;)

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel