2007-03-31 13:50:56

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] STLC2500 Baud Rate & Address Setting

Hi Denis,

> The following patch does two things:
>
> - Adds support for setting the baud rate on the STLC2500.
> - Adds another optional argument to hciattach for use with stlc2500/bgb2xx
> devices that require initialization of the bdaddr. Basically if you specify
> this option on the command line, the address specified will be used during
> stlc2500/bgb2xx initialization. Otherwise a default will be used. The
> manpage has been updated as well.
>
> Let me know if there are any issues!

the patch looks good. However please swap these two:

int (*init) (int fd, struct uart_t *u, struct termios *ti);
+ char *bdaddr;

The callbacks should come always last in a structure.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2007-04-25 23:09:28

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] STLC2500 Baud Rate & Address Setting

Hi Denis,

> Disregard previous, can't keep my patches straight.
>
> Here is the good one.

your patch has been committed to the CVS. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel