2008-07-24 19:38:47

by keith preston

[permalink] [raw]

2008-07-25 16:48:15

by keith preston

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] a2dp_write patch

> Well done, now Im wondering if it isn't possible to use alsa buffer
> all the time instead of copying to a temporary buffer?

You definitely can't depend on the buffer still being there. There
are two options, you can just refuse to process any part of the buffer
that is not a certain size, or you can do what we are trying to do and
store it off temporarily. I think the last is the best solution,
because it makes it easier on the our clients, we have to deal with
the extra instead of an application needed to deal with half processed
buffers.

I mean can't we
> just point to the first pcm frame processed but not encoded? (If not
> freed already by alsa)
> Also there is some code duplication, but still the idea is very good.
> If you could please check the performance with oprofile.
>
>
> --

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2008-07-24 20:45:59

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] a2dp_write patch

Hello Keith,

Well done, now Im wondering if it isn't possible to use alsa buffer
all the time instead of copying to a temporary buffer? I mean can't we
just point to the first pcm frame processed but not encoded? (If not
freed already by alsa)
Also there is some code duplication, but still the idea is very good.
If you could please check the performance with oprofile.


-- =

Luiz Augusto von Dentz
Engenheiro de Computa=E7=E3o

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great priz=
es
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=3D100&url=3D/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2008-08-07 22:06:40

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] a2dp_write patch

Hi Keith,

> > Well done, now Im wondering if it isn't possible to use alsa buffer
> > all the time instead of copying to a temporary buffer?
>
> You definitely can't depend on the buffer still being there. There
> are two options, you can just refuse to process any part of the buffer
> that is not a certain size, or you can do what we are trying to do and
> store it off temporarily. I think the last is the best solution,
> because it makes it easier on the our clients, we have to deal with
> the extra instead of an application needed to deal with half processed
> buffers.

I applied your patch to the BlueZ 4.x repository. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel