2006-06-06 14:25:09

by Frederic Danis

[permalink] [raw]
Subject: [Bluez-devel] [PATCH] Minor classes support

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel


Attachments:
update_dbus_minor_classes.patch (11.64 kB)
(No filename) (0.00 B)
(No filename) (164.00 B)
Download all attachments

2006-06-26 12:35:08

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Minor classes support

Hi Frederic,

> You can find attached this patch updated to latest cvs.

I only applied parts of your patch. The only available major class is
still computer. This needs a little bit more base work before we can
also support other major classes.

Regards

Marcel



Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-06-14 05:44:14

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Minor classes support

Hi Frederic,

> You can find attached a patch to support minor classes with the new DBus
> API.
> This patch updates functions : GetMajorClass, ListAvailableMinorClasses,
> GetMinorClass, GetRemoteMajorClass, GetRemoteMinorClass and dbus-api.txt.
> It also adds some call to exerce them (and discoveries) in dbus-test
> program.

I forgot to include this patch in the final 3.0 release. Can you please
redo it against latest CVS.

Regards

Marcel




_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-08-10 19:02:34

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Minor classes support

Hi Frederic,

> >>We found a bug in DBus function GetRemoteMinorClass when major class is
> >>"imaging". In this case, the minor class can be a combo of minor values
> >>(minor part of the class is not an "index" in a table but a "field of
> >>bit", e.g. "scanner printer").
> >>The patch attached returns the first matching value. It may be useful to
> >>change this API to allow it to return multiple values.
> >
> >I applied the patch to the CVS. We might need some more defined minor
> >class strings in the documentation. Feel free to propose something, but
> >actually I prefer not to return more than one value or a list of
> >strings. This API is supposed to be simple.
> >
> Personnally, I think that returning a list of strings for minor class
> can be the best way (for class of device with minor and subminor like
> peripheral (i.e. "keyboard" "card reader"), or class that can have
> multiple values for minor like imaging(i.e. "scanner" "printer")). If
> you are okay with this I can try to work on a patch.
>
> Regarding documentation in CVS (dbus-api.txt), only subminor for
> peripheral seems to be missing. Am I right ?

the class stuff is messed up and I personally think that we might should
not support all of their weird things. If we can decode it in a sane and
simple way, then we should return an error. In this case the raw three
bytes class values can used and the application has to implement its own
decoder.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-08-10 14:42:37

by Frederic Danis

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Minor classes support

Hello,

>>We found a bug in DBus function GetRemoteMinorClass when major class is
>>"imaging". In this case, the minor class can be a combo of minor values
>>(minor part of the class is not an "index" in a table but a "field of
>>bit", e.g. "scanner printer").
>>The patch attached returns the first matching value. It may be useful to
>>change this API to allow it to return multiple values.
>>
>>
>
>I applied the patch to the CVS. We might need some more defined minor
>class strings in the documentation. Feel free to propose something, but
>actually I prefer not to return more than one value or a list of
>strings. This API is supposed to be simple.
>
>
>
>
Personnally, I think that returning a list of strings for minor class
can be the best way (for class of device with minor and subminor like
peripheral (i.e. "keyboard" "card reader"), or class that can have
multiple values for minor like imaging(i.e. "scanner" "printer")). If
you are okay with this I can try to work on a patch.

Regarding documentation in CVS (dbus-api.txt), only subminor for
peripheral seems to be missing. Am I right ?

Regards

Fred

-----------------------------------------------
It is not by improving the oil lamp that one invents the electric bulb!
-----------------------------------------------
Danis Frederic PalmSource Europe
Software engineer
Mail : mailto:[email protected]
-----------------------------------------------



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2006-08-09 22:20:00

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] Minor classes support

Hi Frederic,

> We found a bug in DBus function GetRemoteMinorClass when major class is
> "imaging". In this case, the minor class can be a combo of minor values
> (minor part of the class is not an "index" in a table but a "field of
> bit", e.g. "scanner printer").
> The patch attached returns the first matching value. It may be useful to
> change this API to allow it to return multiple values.

I applied the patch to the CVS. We might need some more defined minor
class strings in the documentation. Feel free to propose something, but
actually I prefer not to return more than one value or a list of
strings. This API is supposed to be simple.

I also added a GetRemoteClass to return the full 3 bytes class value.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel