2007-03-05 19:14:47

by milosz danielewski

[permalink] [raw]
Subject: Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

Marcel Holtmann <marcel <at> holtmann.org> writes:

>
> Hi Milosz,
>
> > Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h
> > (bluez-libs-devel 3.7.1)? It would be useful, but in such situation I
> > cannot use it...
>
> I think that is simply because nobody needed them before. Feel free to
> implement them and send a patch.

As far, as I can see it's already implemented, just not exposed in header file.

> However UUID32 is the most unused UUID
> type. In general you should either use UUID16 for well known profile and
> service identifiers or UUID128 for your own identifiers.

I've started to implement jsr82. When I create java object representing UUID
it's most convenient to pass 16 byte array from native C to Java. So, when I
iterate over service attributes, have to properly convert SDP_UUID32 to uuid128.
That's why I need to use sdp_uuid32_to_uuid128 (which is already implemented and
working). Only problem is ugly warning "implicit declaration".

milosz danielewski


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel


2007-03-05 21:55:13

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

Hi Milosz,

> >> As I am newbie here, what's the policy of sending patches? Should I
> >> send it to bluez-devel list, or directly to you or whatever?
> >
> > create a unified diff with your changes against the latest CVS code and
> > send it to the BlueZ developer mailing list.
>
> here it goes...

looks good to me. Patch has been applied and committed. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2007-03-05 20:50:26

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

Hi Milosz,

> >> As far, as I can see it's already implemented, just not exposed in header file.
> > then send a patch to fix this. Sounds like a really simple bug.
>
> As I am newbie here, what's the policy of sending patches? Should I
> send it to bluez-devel list, or directly to you or whatever?

create a unified diff with your changes against the latest CVS code and
send it to the BlueZ developer mailing list.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2007-03-05 19:44:56

by milosz danielewski

[permalink] [raw]
Subject: Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

Marcel Holtmann wrote:
>> As far, as I can see it's already implemented, just not exposed in header file.
> then send a patch to fix this. Sounds like a really simple bug.

As I am newbie here, what's the policy of sending patches? Should I
send it to bluez-devel list, or directly to you or whatever?

milosz danielewski

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2007-03-05 20:22:44

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

Hi Milosz,

> > > Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h
> > > (bluez-libs-devel 3.7.1)? It would be useful, but in such situation I
> > > cannot use it...
> >
> > I think that is simply because nobody needed them before. Feel free to
> > implement them and send a patch.
>
> As far, as I can see it's already implemented, just not exposed in header file.
>
> > However UUID32 is the most unused UUID
> > type. In general you should either use UUID16 for well known profile and
> > service identifiers or UUID128 for your own identifiers.
>
> I've started to implement jsr82. When I create java object representing UUID
> it's most convenient to pass 16 byte array from native C to Java. So, when I
> iterate over service attributes, have to properly convert SDP_UUID32 to uuid128.
> That's why I need to use sdp_uuid32_to_uuid128 (which is already implemented and
> working). Only problem is ugly warning "implicit declaration".

then send a patch to fix this. Sounds like a really simple bug.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel