2007-10-08 11:17:39

by Fabien Chevalier

[permalink] [raw]
Subject: [PATCH] STLC2500 updated patch

Marcel & all,

Here is an updated version of the STLC2500 patch. Compared to previous
patch versions, it adds support to speeds up to 4000000 bps.

* Add support for speed up to 4000000 bps.
* Makes the firmware & parameters download optional : even though those
are supposed to be mandatory, practive shows that the chip can run
without them.
* Cleanup the speed setting step : call the Ericsson routines directly
instead of duplicating the code.
* Reset the chip only once after all settings & downloads have been done.

Cheers,

Fabien


Attachments:
hciattach-stl2500-cleanup-and-fix.patch (5.54 kB)
fchevalier.vcf (253.00 B)
Download all attachments

2007-10-09 16:52:07

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] STLC2500 updated patch

Hi Fabien,

> And finally the last of the list:

all of them have been committed to the CVS. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

2007-10-08 12:38:46

by Fabien Chevalier

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] STLC2500 updated patch


And finally the last of the list:

* Makes the firmware & parameters download optional : even though those
are supposed to be mandatory, practive shows that the chip can run
without them.

Cheers,

Fabien


Attachments:
hciattach-stl2500-cleanup-and-fix-4.patch (1.44 kB)
fchevalier.vcf (242.00 B)
Download all attachments

2007-10-08 11:49:34

by Fabien Chevalier

[permalink] [raw]
Subject: Re: [PATCH] STLC2500 updated patch


> please break this down into four separate patches. I hate big patches
> that try to fix everything in one go.
>
Third on the list: Retrieve version string before anything else, remove
bogus resets, add OCF & OGF comments.

Cheers,

Fabien


Attachments:
hciattach-stl2500-cleanup-and-fix-3.patch (1.61 kB)
fchevalier.vcf (242.00 B)
Download all attachments

2007-10-08 11:36:25

by Fabien Chevalier

[permalink] [raw]
Subject: Re: [PATCH] STLC2500 updated patch

Marcel Holtmann wrote:

> please break this down into four separate patches. I hate big patches
> that try to fix everything in one go.
>

Second on the list : remove duplicated code between ericsson and st
initialization methods.

Fabien


Attachments:
hciattach-stl2500-cleanup-and-fix-2.patch (1.72 kB)
fchevalier.vcf (253.00 B)
Download all attachments

2007-10-08 11:28:44

by Fabien Chevalier

[permalink] [raw]
Subject: Re: [PATCH] STLC2500 updated patch


> please break this down into four separate patches. I hate big patches
> that try to fix everything in one go.
>

First of the list : provide support for higher baud rates for ericcson
based chipsets.

Fabien



Attachments:
hciattach-stl2500-cleanup-and-fix-1.patch (1.10 kB)
fchevalier.vcf (242.00 B)
Download all attachments

2007-10-08 11:17:07

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [Bluez-devel] [PATCH] STLC2500 updated patch

Hi Fabien,

> Here is an updated version of the STLC2500 patch. Compared to previous
> patch versions, it adds support to speeds up to 4000000 bps.
>
> * Add support for speed up to 4000000 bps.
> * Makes the firmware & parameters download optional : even though those
> are supposed to be mandatory, practive shows that the chip can run
> without them.
> * Cleanup the speed setting step : call the Ericsson routines directly
> instead of duplicating the code.
> * Reset the chip only once after all settings & downloads have been done.

please break this down into four separate patches. I hate big patches
that try to fix everything in one go.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel